From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Hutw7-0004IX-Da
	for qemu-devel@nongnu.org; Sun, 03 Jun 2007 13:32:15 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Hutw5-0004HM-I4
	for qemu-devel@nongnu.org; Sun, 03 Jun 2007 13:32:14 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Hutw5-0004HJ-F1
	for qemu-devel@nongnu.org; Sun, 03 Jun 2007 13:32:13 -0400
Received: from jive.softhome.net ([66.54.152.27])
	by monty-python.gnu.org with smtp (Exim 4.60)
	(envelope-from <a_mulyadi@softhome.net>) id 1Hutw4-0007O4-Vb
	for qemu-devel@nongnu.org; Sun, 03 Jun 2007 13:32:13 -0400
Message-ID: <4662FD59.40806@softhome.net>
Date: Mon, 04 Jun 2007 00:41:45 +0700
From: Mulyadi Santosa <a_mulyadi@softhome.net>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [RFC] strace-like output for user-linux
References: <Pine.LNX.4.64.0706021230470.21792@trantor.stuart.netsweng.com>
In-Reply-To: <Pine.LNX.4.64.0706021230470.21792@trantor.stuart.netsweng.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org
Cc: anderson@netsweng.com

Hi Stuart

I hope my little advice is correct... but overall, I think you add a 
nice usefuk feature here.

>
> I'm sending this patch out for comments. It adds the capability to get
> strace(1) like output from the target executable in user-linux mode.

+char *format="%s(%ld,%ld,%ld,%ld,%ld,%ld)";
+
+for(i=0;i<nsyscalls;i++)
+    if( scnames[i].nr == num ) {
+        if( scnames[i].format != NULL )
+            format = scnames[i].format;
+        gemu_log(format,scnames[i].name, arg1,arg2,arg3,arg4,arg5,arg6);
+    }--> don't you think we should break() here since we already found 
correct syscall num? otherwise we will continue the loop
+}
+

regards,

Mulyadi