* [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic
@ 2007-06-18 20:08 Aurelien Jarno
2007-06-18 20:15 ` Nigel Horne
2007-06-18 20:25 ` [Qemu-devel] [PATCH, arm] " Paul Brook
0 siblings, 2 replies; 6+ messages in thread
From: Aurelien Jarno @ 2007-06-18 20:08 UTC (permalink / raw)
To: qemu-devel
Hi all,
The patch below fixes a segmentation fault when using the arm emulation
with -nographic.
Bye
Aurelien
Index: hw/versatilepb.c
===================================================================
RCS file: /sources/qemu/qemu/hw/versatilepb.c,v
retrieving revision 1.15
diff -u -d -p -r1.15 versatilepb.c
--- hw/versatilepb.c 3 Jun 2007 15:19:33 -0000 1.15
+++ hw/versatilepb.c 18 Jun 2007 20:04:22 -0000
@@ -10,6 +10,8 @@
#include "vl.h"
#include "arm_pic.h"
+extern int nographic;
+
/* Primary interrupt controller. */
typedef struct vpb_sic_state
@@ -215,7 +217,8 @@ static void versatile_init(int ram_size,
/* The versatile/PB actually has a modified Color LCD controller
that includes hardware cursor support from the PL111. */
- pl110_init(ds, 0x10120000, pic[16], 1);
+ if (!nographic)
+ pl110_init(ds, 0x10120000, pic[16], 1);
pl181_init(0x10005000, sd_bdrv, sic[22], sic[1]);
#if 0
--
.''`. Aurelien Jarno | GPG: 1024D/F1BCDB73
: :' : Debian developer | Electrical Engineer
`. `' aurel32@debian.org | aurelien@aurel32.net
`- people.debian.org/~aurel32 | www.aurel32.net
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic
2007-06-18 20:08 [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic Aurelien Jarno
@ 2007-06-18 20:15 ` Nigel Horne
2007-06-18 20:23 ` Aurelien Jarno
2007-06-18 21:13 ` [Qemu-devel] [PATCH] " Stefan Weil
2007-06-18 20:25 ` [Qemu-devel] [PATCH, arm] " Paul Brook
1 sibling, 2 replies; 6+ messages in thread
From: Nigel Horne @ 2007-06-18 20:15 UTC (permalink / raw)
To: qemu-devel
Aurelien Jarno wrote:
> Hi all,
>
> The patch below fixes a segmentation fault when using the arm emulation
> with -nographic.
>
The sparc emulation in CVS also currently segaults with -nographic. Will
this patch fix that as well?
> Bye
> Aurelien
>
>
>
-Nigel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic
2007-06-18 20:08 [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic Aurelien Jarno
2007-06-18 20:15 ` Nigel Horne
@ 2007-06-18 20:25 ` Paul Brook
1 sibling, 0 replies; 6+ messages in thread
From: Paul Brook @ 2007-06-18 20:25 UTC (permalink / raw)
To: qemu-devel; +Cc: Aurelien Jarno
On Monday 18 June 2007, Aurelien Jarno wrote:
> Hi all,
>
> The patch below fixes a segmentation fault when using the arm emulation
> with -nographic.
No. This is the wrong way to fix this.
Fix the segfault, don't disable the device emulation.
Paul
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2007-06-19 14:08 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-18 20:08 [Qemu-devel] [PATCH, arm] Segmentation fault when run with -nographic Aurelien Jarno
2007-06-18 20:15 ` Nigel Horne
2007-06-18 20:23 ` Aurelien Jarno
2007-06-18 21:13 ` [Qemu-devel] [PATCH] " Stefan Weil
2007-06-19 14:08 ` Aurelien Jarno
2007-06-18 20:25 ` [Qemu-devel] [PATCH, arm] " Paul Brook
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).