From: Stefan Weil <weil@mail.berlios.de>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] qemu exec.c monitor.c
Date: Sun, 01 Jul 2007 19:29:09 +0200 [thread overview]
Message-ID: <4687E465.9010505@mail.berlios.de> (raw)
In-Reply-To: <E1I4dO8-00042e-8T@cvs.savannah.gnu.org>
ANSI / POSIX do not define "wa" as mode string for fopen.
I have no idea how many implementations of libc
will fail with this mode which was introduced by
the latest version of exec.c.
The standard mode for append is just "a".
Even better (because it is faster and creates smaller
log files for Windows) is "ab" for append and "wb"
otherwise.
Stefan
Paul Brook schrieb:
> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Paul Brook <pbrook> 07/06/30 13:53:24
>
> Modified files:
> . : exec.c monitor.c
>
> Log message:
> Allow changing log filename.
> Close logfile when logging is disabled.
next prev parent reply other threads:[~2007-07-01 17:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-30 13:53 [Qemu-devel] qemu exec.c monitor.c Paul Brook
2007-07-01 17:29 ` Stefan Weil [this message]
2007-07-01 18:26 ` Paul Brook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4687E465.9010505@mail.berlios.de \
--to=weil@mail.berlios.de \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).