From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1I53EY-0004a5-Aa
	for qemu-devel@nongnu.org; Sun, 01 Jul 2007 13:29:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1I53EW-0004XH-S8
	for qemu-devel@nongnu.org; Sun, 01 Jul 2007 13:29:13 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1I53EW-0004Wr-Kx
	for qemu-devel@nongnu.org; Sun, 01 Jul 2007 13:29:12 -0400
Received: from moutng.kundenserver.de ([212.227.126.179])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <SRS0=RlCW=L7=mail.berlios.de=weil@srs.kundenserver.de>)
	id 1I53EV-00041I-Q9
	for qemu-devel@nongnu.org; Sun, 01 Jul 2007 13:29:12 -0400
Message-ID: <4687E465.9010505@mail.berlios.de>
Date: Sun, 01 Jul 2007 19:29:09 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] qemu exec.c monitor.c
References: <E1I4dO8-00042e-8T@cvs.savannah.gnu.org>
In-Reply-To: <E1I4dO8-00042e-8T@cvs.savannah.gnu.org>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

ANSI / POSIX do not define "wa" as mode string for fopen.
I have no idea how many implementations of libc
will fail with this mode which was introduced by
the latest version of exec.c.

The standard mode for append is just "a".
Even better (because it is faster and creates smaller
log files for Windows) is "ab" for append and "wb"
otherwise.

Stefan

Paul Brook schrieb:
> CVSROOT: /sources/qemu
> Module name: qemu
> Changes by: Paul Brook <pbrook> 07/06/30 13:53:24
>
> Modified files:
> . : exec.c monitor.c
>
> Log message:
> Allow changing log filename.
> Close logfile when logging is disabled.