From: Thomas Huth <thuth@redhat.com>
To: Omar Sandoval <osandov@osandov.com>, qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, qemu-ppc@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
David Hildenbrand <david@redhat.com>,
Ilya Leoshkevich <iii@linux.ibm.com>,
Nicholas Piggin <npiggin@gmail.com>,
Daniel Henrique Barboza <danielhb413@gmail.com>,
linux-debuggers@vger.kernel.org,
QEMU Trivial <qemu-trivial@nongnu.org>
Subject: Re: [PATCH 1/2] target/s390x/arch_dump: use correct byte order for pid
Date: Wed, 19 Jun 2024 07:57:49 +0200 [thread overview]
Message-ID: <4687c59a-1427-4215-a58d-cb84dd27f9ff@redhat.com> (raw)
In-Reply-To: <5929f76d536d355afd04af51bf293695a1065118.1718771802.git.osandov@osandov.com>
On 19/06/2024 07.00, Omar Sandoval wrote:
> The pid field of prstatus needs to be big endian like all of the other
> fields.
>
> Fixes: f738f296eaae ("s390x/arch_dump: pass cpuid into notes sections")
> Signed-off-by: Omar Sandoval <osandov@osandov.com>
> ---
> target/s390x/arch_dump.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/target/s390x/arch_dump.c b/target/s390x/arch_dump.c
> index 7e8a1b4fc0..029d91d93a 100644
> --- a/target/s390x/arch_dump.c
> +++ b/target/s390x/arch_dump.c
> @@ -102,7 +102,7 @@ static void s390x_write_elf64_prstatus(Note *note, S390CPU *cpu, int id)
> regs->acrs[i] = cpu_to_be32(cpu->env.aregs[i]);
> regs->gprs[i] = cpu_to_be64(cpu->env.regs[i]);
> }
> - note->contents.prstatus.pid = id;
> + note->contents.prstatus.pid = cpu_to_be32(id);
> }
>
> static void s390x_write_elf64_fpregset(Note *note, S390CPU *cpu, int id)
Reviewed-by: Thomas Huth <thuth@redhat.com>
next prev parent reply other threads:[~2024-06-19 5:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-19 5:00 [PATCH 0/2] arch_dump: fix prstatus pid on s390x and ppc Omar Sandoval
2024-06-19 5:00 ` [PATCH 1/2] target/s390x/arch_dump: use correct byte order for pid Omar Sandoval
2024-06-19 5:57 ` Thomas Huth [this message]
2024-06-19 5:00 ` [PATCH 2/2] target/ppc/arch_dump: set prstatus pid to cpuid Omar Sandoval
2024-06-19 6:01 ` Thomas Huth
2024-06-24 7:22 ` Harsh Prateek Bora
2024-06-24 6:17 ` [PATCH 0/2] arch_dump: fix prstatus pid on s390x and ppc Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4687c59a-1427-4215-a58d-cb84dd27f9ff@redhat.com \
--to=thuth@redhat.com \
--cc=danielhb413@gmail.com \
--cc=david@redhat.com \
--cc=iii@linux.ibm.com \
--cc=linux-debuggers@vger.kernel.org \
--cc=npiggin@gmail.com \
--cc=osandov@osandov.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=richard.henderson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).