From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1I5PfH-0005GU-Dh
	for qemu-devel@nongnu.org; Mon, 02 Jul 2007 13:26:19 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1I5PfF-0005EI-Dn
	for qemu-devel@nongnu.org; Mon, 02 Jul 2007 13:26:18 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1I5PfF-0005E5-7w
	for qemu-devel@nongnu.org; Mon, 02 Jul 2007 13:26:17 -0400
Received: from mx2.suse.de ([195.135.220.15])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <agraf@suse.de>) id 1I5PfE-0002xA-Rl
	for qemu-devel@nongnu.org; Mon, 02 Jul 2007 13:26:17 -0400
Received: from Relay2.suse.de (mail2.suse.de [195.135.221.8])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mx2.suse.de (Postfix) with ESMTP id 72D472187B
	for <qemu-devel@nongnu.org>; Mon,  2 Jul 2007 19:26:10 +0200 (CEST)
Message-ID: <468935C9.5000201@suse.de>
Date: Mon, 02 Jul 2007 19:28:41 +0200
From: Alexander Graf <agraf@suse.de>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------050906030402040903090808"
Subject: [Qemu-devel] [PATCH] Netlink broken if endianness is wrong
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is a multi-part message in MIME format.
--------------050906030402040903090808
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit

While using i386 X applications on ppc I had to find out that netlink
communication is not endianness-aware (X apps just hang forever waiting
for a reply on a netlink socket). Because it is basically only used for
programs that are not really supposed to be emulated (like udev afaik)
there should be no problem to just shut it off.

Alex

--------------050906030402040903090808
Content-Type: text/plain;
 name="netlink"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="netlink"

Index: qemu/linux-user/syscall.c
===================================================================
--- qemu.orig/linux-user/syscall.c
+++ qemu/linux-user/syscall.c
@@ -898,6 +906,7 @@ static long do_socket(int domain, int ty
         break;
     }
 #endif
+    if(domain == PF_NETLINK) return -EAFNOSUPPORT; /* do not make NETLINK socket connections possible */
     return get_errno(socket(domain, type, protocol));
 }
 

--------------050906030402040903090808--