From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] linux-user EFAULT implementation
Date: Fri, 06 Jul 2007 18:08:23 +0200 [thread overview]
Message-ID: <468E68F7.8070005@bellard.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0707061111150.12799@trantor.stuart.netsweng.com>
Please update page_check_range() (and other related functions) to return
-EFAULT instead of EFAULT in case of error.
Moreover, I believe using similar functions as Linux for memory access
(copyfromuser, copytouser, get_user, put_user) would be cleaner.
Regards,
Fabrice.
Stuart Anderson wrote:
>
> Here is a refresh of the linux-user EFAULT patch vs todays cvs. This
> patch has now received a lot more runtime, and a couple of bug have been
> fixed that affected some of the socket APIs.
>
> The purpose of this patch is to detect bad pointers and return EFAULT
> instead of just crashing when the bad pointers are used by qemu.
>
>
> Stuart
next prev parent reply other threads:[~2007-07-06 16:08 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-06 15:15 [Qemu-devel] [PATCH] linux-user EFAULT implementation Stuart Anderson
2007-07-06 16:08 ` Fabrice Bellard [this message]
2007-07-06 16:55 ` Stuart Anderson
2007-07-06 18:45 ` Stuart Anderson
2007-07-09 11:41 ` Stuart Anderson
2007-07-09 12:02 ` Stuart Anderson
2007-07-09 21:15 ` Fabrice Bellard
2007-07-10 2:22 ` Stuart Anderson
2007-07-10 12:38 ` Paul Brook
2007-07-10 20:45 ` Fabrice Bellard
2007-07-10 21:09 ` Stuart Anderson
2007-07-13 17:55 ` Stuart Anderson
2007-07-20 20:16 ` Stuart Anderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=468E68F7.8070005@bellard.org \
--to=fabrice@bellard.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).