qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: "Philippe Mathieu-Daudé" <f4bug@amsat.org>, qemu-devel@nongnu.org
Cc: "Kevin Wolf" <kwolf@redhat.com>,
	"Peter Maydell" <peter.maydell@linaro.org>,
	"Yoshinori Sato" <ysato@users.sourceforge.jp>,
	qemu-block@nongnu.org, "Magnus Damm" <magnus.damm@gmail.com>,
	"Max Reitz" <mreitz@redhat.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: Re: [PATCH v4 0/8] hw/sh4: Kconfig cleanups
Date: Thu, 25 Feb 2021 11:09:41 +0100	[thread overview]
Message-ID: <468b0b50-c822-6771-fad4-2c3d5bee5277@redhat.com> (raw)
In-Reply-To: <20210222141514.2646278-1-f4bug@amsat.org>

On 22/02/21 15:15, Philippe Mathieu-Daudé wrote:
> Missing review: 1 (license)
> 
> Since v3:
> - Include full MIT license text (Peter)
> 
> Since v2:
> - Added missing TC58128/SH_PCI Kconfig entries (Peter)
> 
> Since v1:
> - Addressed Peter Maydell review comments from
> https://www.mail-archive.com/qemu-block@nongnu.org/msg80599.html
> 
> Philippe Mathieu-Daudé (8):
>    hw/sh4: Add missing license
>    hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board
>    hw/intc: Introduce SH_INTC Kconfig entry
>    hw/char: Introduce SH_SCI Kconfig entry
>    hw/timer: Introduce SH_TIMER Kconfig entry
>    hw/block: Introduce TC58128 eeprom Kconfig entry
>    hw/pci-host: Introduce SH_PCI Kconfig entry
>    hw/sh4: Remove now unused CONFIG_SH4 from Kconfig
> 
>   include/hw/sh4/sh.h           | 31 ++++++++++++++++++++++++++++---
>   hw/block/tc58128.c            | 26 ++++++++++++++++++++++++++
>   hw/{sh4 => pci-host}/sh_pci.c |  0
>   MAINTAINERS                   |  6 ++++++
>   hw/block/Kconfig              |  3 +++
>   hw/block/meson.build          |  2 +-
>   hw/char/Kconfig               |  3 +++
>   hw/char/meson.build           |  2 +-
>   hw/intc/Kconfig               |  3 +++
>   hw/intc/meson.build           |  2 +-
>   hw/pci-host/Kconfig           |  4 ++++
>   hw/pci-host/meson.build       |  1 +
>   hw/sh4/Kconfig                | 12 ++++++------
>   hw/sh4/meson.build            |  1 -
>   hw/timer/Kconfig              |  4 ++++
>   hw/timer/meson.build          |  2 +-
>   16 files changed, 88 insertions(+), 14 deletions(-)
>   rename hw/{sh4 => pci-host}/sh_pci.c (100%)
> 

Acked-by: Paolo Bonzini <pbonzini@redhat.com>

Paolo



  parent reply	other threads:[~2021-02-25 10:10 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-22 14:15 [PATCH v4 0/8] hw/sh4: Kconfig cleanups Philippe Mathieu-Daudé
2021-02-22 14:15 ` [PATCH v4 1/8] hw/sh4: Add missing license Philippe Mathieu-Daudé
2021-02-22 14:15 ` [PATCH v4 2/8] hw/sh4: Add missing Kconfig dependency on SH7750 for the R2D board Philippe Mathieu-Daudé
2021-02-22 14:15 ` [PATCH v4 3/8] hw/intc: Introduce SH_INTC Kconfig entry Philippe Mathieu-Daudé
2021-02-22 14:15 ` [PATCH v4 4/8] hw/char: Introduce SH_SCI " Philippe Mathieu-Daudé
2021-02-22 14:15 ` [PATCH v4 5/8] hw/timer: Introduce SH_TIMER " Philippe Mathieu-Daudé
2021-02-22 14:15 ` [PATCH v4 6/8] hw/block: Introduce TC58128 eeprom " Philippe Mathieu-Daudé
2021-02-22 14:15 ` [PATCH v4 7/8] hw/pci-host: Introduce SH_PCI " Philippe Mathieu-Daudé
2021-02-22 14:15 ` [PATCH v4 8/8] hw/sh4: Remove now unused CONFIG_SH4 from Kconfig Philippe Mathieu-Daudé
2021-02-24 15:40 ` [PATCH v4 0/8] hw/sh4: Kconfig cleanups Richard Henderson
2021-02-25 10:09 ` Paolo Bonzini [this message]
2021-02-26 18:01 ` Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=468b0b50-c822-6771-fad4-2c3d5bee5277@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=f4bug@amsat.org \
    --cc=kwolf@redhat.com \
    --cc=magnus.damm@gmail.com \
    --cc=marcandre.lureau@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=ysato@users.sourceforge.jp \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).