From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IMiht-0008E2-KH for qemu-devel@nongnu.org; Sun, 19 Aug 2007 07:12:33 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IMihs-0008D5-7R for qemu-devel@nongnu.org; Sun, 19 Aug 2007 07:12:32 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IMihr-0008Ck-A2 for qemu-devel@nongnu.org; Sun, 19 Aug 2007 07:12:31 -0400 Received: from il.qumranet.com ([82.166.9.18]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IMihq-0006hB-UN for qemu-devel@nongnu.org; Sun, 19 Aug 2007 07:12:31 -0400 Message-ID: <46C825AB.604@qumranet.com> Date: Sun, 19 Aug 2007 14:12:43 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] Set apic instance number for savevm References: <1187020655319-git-send-email-avi@qumranet.com> In-Reply-To: <1187020655319-git-send-email-avi@qumranet.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Fabrice Bellard , ths@networkno.de Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org Avi Kivity wrote: > This allows save/restore (and live migration on kvm) of smp guests. > > Index: hw/apic.c > =================================================================== > RCS file: /sources/qemu/qemu/hw/apic.c,v > retrieving revision 1.13 > diff -u -r1.13 apic.c > --- hw/apic.c 3 Apr 2007 16:38:34 -0000 1.13 > +++ hw/apic.c 13 Aug 2007 15:54:50 -0000 > @@ -832,7 +832,7 @@ > } > s->timer = qemu_new_timer(vm_clock, apic_timer, s); > > - register_savevm("apic", 0, 2, apic_save, apic_load, s); > + register_savevm("apic", s->id, 2, apic_save, apic_load, s); > qemu_register_reset(apic_reset, s); > > local_apics[s->id] = s; > > Fabrice or Thiemo, can you take a look at this patch? -- error compiling committee.c: too many arguments to function