From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IO8m2-0006Ik-K3 for qemu-devel@nongnu.org; Thu, 23 Aug 2007 05:14:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IO8m1-0006Gk-GY for qemu-devel@nongnu.org; Thu, 23 Aug 2007 05:14:41 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IO8m1-0006GR-3b for qemu-devel@nongnu.org; Thu, 23 Aug 2007 05:14:41 -0400 Received: from il.qumranet.com ([82.166.9.18]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IO8m0-00019K-Kn for qemu-devel@nongnu.org; Thu, 23 Aug 2007 05:14:40 -0400 Message-ID: <46CD4FFE.1090809@qumranet.com> Date: Thu, 23 Aug 2007 12:14:38 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH][RFC] SVM support References: <46CC956B.2060002@suse.de> <46CC9BF7.6040002@suse.de> In-Reply-To: <46CC9BF7.6040002@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Alexander Graf wrote: > Blue Swirl wrote: > >> On 8/22/07, Alexander Graf wrote: >> >> >>> - All interceptions (well, maybe I did oversee one or two) >>> >>> >> Nice work! For better performance, you should do the op.c checks >> statically at translation time (if possible). >> >> >> >> > Thanks. I thought about that first as well, but can't. The information > if an intercept should occur is defined in the VMCB, which is passed as > argument on VMRUN (so whenever one enters the VM). This means that the > very same TB can be executed with completely different intercepts, which > means I have to fall back to runtime detection in op.c. > You can have the intercept vector be a part of the TB lookup key. So, if the same code is executed natively, or with different intercept vectors, it gets a different TB. Qemu already does this for a number of things like cpu operating mode, cs base, etc. -- error compiling committee.c: too many arguments to function