From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IOifN-0008Dt-S6
	for qemu-devel@nongnu.org; Fri, 24 Aug 2007 19:34:13 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IOifL-0008AE-Dd
	for qemu-devel@nongnu.org; Fri, 24 Aug 2007 19:34:12 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IOifK-00089t-Ry
	for qemu-devel@nongnu.org; Fri, 24 Aug 2007 19:34:10 -0400
Received: from sp604005mt.neufgp.fr ([84.96.92.11] helo=smtp.Neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1IOifK-0001dF-4i
	for qemu-devel@nongnu.org; Fri, 24 Aug 2007 19:34:10 -0400
Received: from [84.102.211.141] by sp604005mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0JNA00KMPXGLU5Q8@sp604005mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sat, 25 Aug 2007 01:33:57 +0200 (CEST)
Date: Sat, 25 Aug 2007 01:33:38 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] Re: PATCH, RFC: Generic DMA framework
In-reply-to: <200708242118.54118.paul@codesourcery.com>
Message-id: <46CF6AD2.7040905@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT
References: <f43fc5580708141248l3ea425e9q5f3851f5096f1dee@mail.gmail.com>
	<f43fc5580708241240q6d28c706q397e88605e9c2723@mail.gmail.com>
	<200708242118.54118.paul@codesourcery.com>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Paul Brook wrote:
> On Friday 24 August 2007, Blue Swirl wrote:
>> I have now converted the ISA DMA devices (SB16, FDC), most PCI devices
>> and targets.
>>
>> gdma.diff: Generic DMA
>> pc_ppc_dma_to_gdma.diff: Convert x86 and PPC to GDMA
>> pc_sb16_to_gdma.diff: Convert SB16 to GDMA
>> pc_fdc_to_gdma.diff: FDC
>> pc_dma_cleanup.diff: Remove unused functions
>> sparc_gdma.diff: Convert Sparc32 to GDMA
>> sparc32_dma_esp_le_to_gdma.diff: Convert ESP and Lance
>> sun4c.diff: Preliminary Sun4c (Sparcstation-1) support
>> pci_gdma.diff: Convert PCI devices and targets
>>
>> Any comments? The patches are a bit intrusive and I can't test the
>> targets except that they compile.
> 
> Shouldn't the PCI DMA object be a property of the PCI bus?
> ie. we don't want/need to pass it round as a separate parameter. It can be 
> inferred form the device/bus.

I agree. Moreover the DMA is bus specific so I don't see a need to add a 
generic DMA layer.

Regards,

Fabrice.