From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IOk8k-0008NS-Tf
	for qemu-devel@nongnu.org; Fri, 24 Aug 2007 21:08:38 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IOk8i-0008NB-Ib
	for qemu-devel@nongnu.org; Fri, 24 Aug 2007 21:08:37 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IOk8i-0008N8-B9
	for qemu-devel@nongnu.org; Fri, 24 Aug 2007 21:08:36 -0400
Received: from sp604001mt.neufgp.fr ([84.96.92.60] helo=Smtp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1IOj0C-0001PA-F7
	for qemu-devel@nongnu.org; Fri, 24 Aug 2007 19:55:45 -0400
Received: from [84.102.211.141] by sp604001mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0JNA00AGZYGUXRP1@sp604001mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Sat, 25 Aug 2007 01:55:42 +0200 (CEST)
Date: Sat, 25 Aug 2007 01:55:23 +0200
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH][RFC] SVM support
In-reply-to: <46CF11B2.5070201@suse.de>
Message-id: <46CF6FEB.1080504@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1; format=flowed
Content-transfer-encoding: 7BIT
References: <46CC956B.2060002@suse.de> <46CF11B2.5070201@suse.de>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org


> This is a reworked version of the same patch, where I can now boot into
> a x86_64 Linux kernel.
> I rewrote all the access functions for the VMCB, so this time everything
> should work just fine on BE-machines. As suggested I moved the injection
> detection to translate.c, so the non-virtualized machine should be as
> fast as before (w/o svm support), while the virtual one got a speed
> boost from that as well.
> I removed the EIP hack and set EIP every time an interception occurs, so
> unlike the previous version this patch really should have no negative
> effect on speed any more.
> 
> If any of the people on this list using SVM (kvm developers, maybe xen
> developers) could have a deep look into this I'd be really thankful.

Some notes:

- Saving and restoring CC_SRC and CC_DST is not correct as they do not 
belong to the real processor state. You must save and restore eflags 
correctly instead.

- Avoid using macros when inline functions suffice.

Regards,

Fabrice.