From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IUPoD-0003Vm-4E for qemu-devel@nongnu.org; Sun, 09 Sep 2007 12:38:53 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IUPoA-0003VI-6V for qemu-devel@nongnu.org; Sun, 09 Sep 2007 12:38:51 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IUPoA-0003VF-2g for qemu-devel@nongnu.org; Sun, 09 Sep 2007 12:38:50 -0400 Received: from il.qumranet.com ([82.166.9.18]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IUPo9-0002Sx-Kp for qemu-devel@nongnu.org; Sun, 09 Sep 2007 12:38:49 -0400 Message-ID: <46E42193.5020301@qumranet.com> Date: Sun, 09 Sep 2007 19:38:43 +0300 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [kvm-devel] [Qemu-devel] Re: expose host CPU features to guests References: <20070905174530.GA3945@karma.qumranet.com> <200709091625.59859.paul@codesourcery.com> <46E4114C.6090804@qumranet.com> <200709091712.15743.paul@codesourcery.com> In-Reply-To: <200709091712.15743.paul@codesourcery.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paul Brook Cc: kvm-devel , qemu-devel@nongnu.org Paul Brook wrote: >>> What you really want to do is ask your virtualization module what >>> features it supports. >>> >> Yes, that needs to be an additional filter. >> > > I'd have thought that would be the *only* interesting set for autodetection. > > Yes, you're right. It's pointless to issue cpuid in userspace and mask it in the kernel; rather we can issue it in the kernel , mask out unsupported features, and return it to userspace. -- error compiling committee.c: too many arguments to function