From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IXyoI-0005Ro-O8 for qemu-devel@nongnu.org; Wed, 19 Sep 2007 08:37:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IXyoG-0005P8-3h for qemu-devel@nongnu.org; Wed, 19 Sep 2007 08:37:42 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IXyoG-0005Oz-0U for qemu-devel@nongnu.org; Wed, 19 Sep 2007 08:37:40 -0400 Received: from pih-relay04.plus.net ([212.159.14.131]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IXyoF-0004w7-K0 for qemu-devel@nongnu.org; Wed, 19 Sep 2007 08:37:39 -0400 Received: from [212.159.106.41] (helo=bandsman.co.uk) by pih-relay04.plus.net with esmtp (Exim) id 1IXyoD-0000jl-S0 for qemu-devel@nongnu.org; Wed, 19 Sep 2007 13:37:38 +0100 Received: from [192.168.1.2] (njh [192.168.1.2]) (authenticated bits=0) by bandsman.co.uk (8.14.1/8.14.1) with ESMTP id l8JCbZi4021382 for ; Wed, 19 Sep 2007 13:37:36 +0100 Message-ID: <46F1180C.6050905@bandsman.co.uk> Date: Wed, 19 Sep 2007 13:37:32 +0100 From: Nigel Horne MIME-Version: 1.0 Subject: Re: [Qemu-devel] Mips guest References: <46F0EA2E.2080609@bandsman.co.uk> In-Reply-To: Content-Type: multipart/mixed; boundary="------------020502030805040603080103" Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org This is a multi-part message in MIME format. --------------020502030805040603080103 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit I suddenly remembered I'd forgotten to do a "make clean" after my last checkout (oops). So I did that, and got this compilation error: ... In file included from /home/njh/src/qemu/linux-user/syscall.c:4040: /home/njh/src/qemu/linux-user/syscall.c: In function `do_syscall': /usr/include/bits/unistd.h:62: sorry, unimplemented: inlining failed in call to 'pread': recursive inlining /home/njh/src/qemu/linux-user/syscall.c:63: sorry, unimplemented: called from here make[1]: *** [syscall.o] Error 1 make[1]: Leaving directory `/home/njh/src/qemu/i386-linux-user' make: *** [subdir-i386-linux-user] Error 2 This is because both unistd.h and linux/unistd.h are included. Remove unistd.h from line 27 and that compiles OK. The next (similar) failure is in mmap.c: ... /home/njh/src/qemu/linux-user/mmap.c:392: warning: comparison between signed and unsigned /home/njh/src/qemu/linux-user/mmap.c: In function `mmap_frag': /usr/include/bits/unistd.h:62: sorry, unimplemented: inlining failed in call to 'pread': recursive inlining /home/njh/src/qemu/linux-user/mmap.c:63: sorry, unimplemented: called from here /home/njh/src/qemu/linux-user/mmap.c:139: warning: ignoring return value of `pread', declared with attribute warn_unused_result Here the fix was on line 24 to replace #include with Then: ... /home/njh/src/qemu/linux-user/flatload.c: In function `target_pread': /usr/include/bits/unistd.h:62: sorry, unimplemented: inlining failed in call to 'pread': recursive inlining /home/njh/src/qemu/linux-user/flatload.c:63: sorry, unimplemented: called from here Which needs the same fix at line 41. I suspect these may break building on other OS's, so a cleaner fix will be needed. The next compilation error is: ... /home/njh/src/qemu/monitor.c:52: warning: function declaration isn't a prototype /home/njh/src/qemu/monitor.c:61: error: array size missing in 'term_cmds' /home/njh/src/qemu/monitor.c:62: error: array size missing in 'info_cmds' The fix is to change term_cmds[] to *term_cmds, and similarly to info_cmds. This is less than optimal, but it gets the code compiling pending a code tidy. The good news is that with these fixes it all compiles and the mips guest runs again (note to self: remember to run make clean ;-) ) -Nigel -- Nigel Horne. Adjudicator, Arranger, Band Trainer, Composer, Tutor, Typesetter. NJH Music, Barnsley, UK. ICQ#20252325 njh@bandsman.co.uk http://www.bandsman.co.uk --------------020502030805040603080103 Content-Type: text/x-vcard; charset=utf-8; name="njh.vcf" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="njh.vcf" begin:vcard fn:Nigel Horne n:Horne;Nigel org:NJH Music adr:Pogmoor;;28 Wharfedale Road;Barnsley;South Yorkshire;S75 2LJ;UK email;internet:njh@bandsman.co.uk tel;fax:+44 870 705 9334 note:Skype: nigelhorne x-mozilla-html:FALSE url:http://www.bandsman.co.uk version:2.1 end:vcard --------------020502030805040603080103--