From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IZUGM-0007lZ-N0 for qemu-devel@nongnu.org; Sun, 23 Sep 2007 12:24:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IZUGL-0007jv-T1 for qemu-devel@nongnu.org; Sun, 23 Sep 2007 12:24:54 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IZUGL-0007jY-MR for qemu-devel@nongnu.org; Sun, 23 Sep 2007 12:24:53 -0400 Received: from sp604002mt.neufgp.fr ([84.96.92.61] helo=sMtp.neuf.fr) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IZUGL-0005pB-AL for qemu-devel@nongnu.org; Sun, 23 Sep 2007 12:24:53 -0400 Received: from [84.99.204.182] by sp604002mt.gpm.neuf.ld (Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006)) with ESMTP id <0JOT00FLGXJ37C71@sp604002mt.gpm.neuf.ld> for qemu-devel@nongnu.org; Sun, 23 Sep 2007 18:23:27 +0200 (CEST) Date: Sun, 23 Sep 2007 18:23:02 +0200 From: Fabrice Bellard Subject: Re: [Qemu-devel] qemu cpu-all.h cpu-exec.c exec.c target-i386/cp... In-reply-to: Message-id: <46F692E6.3070507@bellard.org> MIME-version: 1.0 Content-type: text/plain; charset=ISO-8859-1; format=flowed Content-transfer-encoding: 7BIT References: Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Hi, The code would be simpler if some intercept tests were done at runtime in the corresponding helpers (for crN, drN and MSR registers, I/Os). This is especially true when the existing helpers can return an exception at runtime. Complicating the translator to handle SVM is definitely not the way I would have handled it. For I/Os for example, there was already the necessary support to do runtime tests (see gen_check_io()). Adding one bit to return the prefix information is all what it needed. The current code is actually slower because new ops were added for each I/O instruction. Regards, Fabrice. Thiemo Seufer wrote: > CVSROOT: /sources/qemu > Module name: qemu > Changes by: Thiemo Seufer 07/09/23 15:28:04 > > Modified files: > . : cpu-all.h cpu-exec.c exec.c > target-i386 : cpu.h exec.h helper.c helper2.c op.c > translate.c > > Log message: > SVM Support, by Alexander Graf. > > CVSWeb URLs: > http://cvs.savannah.gnu.org/viewcvs/qemu/cpu-all.h?cvsroot=qemu&r1=1.75&r2=1.76 > http://cvs.savannah.gnu.org/viewcvs/qemu/cpu-exec.c?cvsroot=qemu&r1=1.115&r2=1.116 > http://cvs.savannah.gnu.org/viewcvs/qemu/exec.c?cvsroot=qemu&r1=1.105&r2=1.106 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/cpu.h?cvsroot=qemu&r1=1.47&r2=1.48 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/exec.h?cvsroot=qemu&r1=1.36&r2=1.37 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/helper.c?cvsroot=qemu&r1=1.87&r2=1.88 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/helper2.c?cvsroot=qemu&r1=1.51&r2=1.52 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/op.c?cvsroot=qemu&r1=1.50&r2=1.51 > http://cvs.savannah.gnu.org/viewcvs/qemu/target-i386/translate.c?cvsroot=qemu&r1=1.70&r2=1.71 > > > >