From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IZrfJ-0006g6-W0
	for qemu-devel@nongnu.org; Mon, 24 Sep 2007 13:24:14 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IZrfG-0006ej-WD
	for qemu-devel@nongnu.org; Mon, 24 Sep 2007 13:24:13 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IZrfG-0006ed-OR
	for qemu-devel@nongnu.org; Mon, 24 Sep 2007 13:24:10 -0400
Received: from moutng.kundenserver.de ([212.227.126.188])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <SRS0=BOpI=OU=mail.berlios.de=weil@srs.kundenserver.de>)
	id 1IZrfG-0006Jm-JA
	for qemu-devel@nongnu.org; Mon, 24 Sep 2007 13:24:10 -0400
Message-ID: <46F7F2B6.2080105@mail.berlios.de>
Date: Mon, 24 Sep 2007 19:24:06 +0200
From: Stefan Weil <weil@mail.berlios.de>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [Bug] Timer bugs in hw/m48t59.c?
References: <4602EA31.1010009@weilnetz.de>
In-Reply-To: <4602EA31.1010009@weilnetz.de>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Hello,

the bug mentioned in my previous mail is still open.
Could someone please add the patch to CVS HEAD
(or find another solution)?

Thank you
Stefan

Stefan Weil schrieb:
> Hi,
>
> could SPARC or PPC users please check whether the timer code
> in hw/m48t59.c is really correct?
>
> I expect a crash in qemu_mod_timer after wd_timer = NULL and
> a call to qemu_mod_timer with this NULL value.
>
> The same applies to alrm_timer.
>
> I wrote a quick-and-dirty patch, but think that even more
> old code could be removed.
>
> Stefan
>
>
>
> diff -u -b -B -r1.8 m48t59.c
> --- hw/m48t59.c 14 Jun 2006 12:41:34 -0000 1.8
> +++ hw/m48t59.c 22 Mar 2007 20:29:15 -0000
> @@ -155,7 +155,6 @@
> NVRAM->alarm = mktime(tm);
> if (NVRAM->alrm_timer != NULL) {
> qemu_del_timer(NVRAM->alrm_timer);
> - NVRAM->alrm_timer = NULL;
> }
> if (NVRAM->alarm - time(NULL) > 0)
> qemu_mod_timer(NVRAM->alrm_timer, NVRAM->alarm * 1000);
> @@ -184,7 +183,6 @@
>
> if (NVRAM->wd_timer != NULL) {
> qemu_del_timer(NVRAM->wd_timer);
> - NVRAM->wd_timer = NULL;
> }
> NVRAM->buffer[0x1FF0] &= ~0x80;
> if (value != 0) {
>
>
>
> _______________________________________________
> Qemu-devel mailing list
> Qemu-devel@nongnu.org
> http://lists.nongnu.org/mailman/listinfo/qemu-devel
>