From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IZtTQ-0000mV-OV for qemu-devel@nongnu.org; Mon, 24 Sep 2007 15:20:04 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IZtTQ-0000m4-06 for qemu-devel@nongnu.org; Mon, 24 Sep 2007 15:20:04 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IZtTP-0000ly-SP for qemu-devel@nongnu.org; Mon, 24 Sep 2007 15:20:03 -0400 Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IZtTP-00027k-Gf for qemu-devel@nongnu.org; Mon, 24 Sep 2007 15:20:03 -0400 Received: from list by ciao.gmane.org with local (Exim 4.43) id 1IZtTG-0002af-Kx for qemu-devel@nongnu.org; Mon, 24 Sep 2007 19:19:55 +0000 Received: from d83-184-165-199.cust.tele2.it ([83.184.165.199]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 24 Sep 2007 19:19:54 +0000 Received: from lorenzo.campedelli by d83-184-165-199.cust.tele2.it with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 24 Sep 2007 19:19:54 +0000 From: Lorenzo Campedelli Date: Mon, 24 Sep 2007 21:19:43 +0200 Message-ID: <46F80DCF.2000201@tele2.it> References: <219e947f0709221443l494e4c46w6efafce989dbb867@mail.gmail.com> <219e947f0709240350j6e011564j31a84015910ab481@mail.gmail.com> <219e947f0709240712q3b8ccdaej491f777fbdc76bce@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit In-Reply-To: Sender: news Subject: [Qemu-devel] Re: [PATCH] vvfat mbr fixes Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Johannes Schindelin wrote: > Hi, > > On Mon, 24 Sep 2007, Ivan Kalvachev wrote: > >> 2007/9/24, Johannes Schindelin : >> >>> On Mon, 24 Sep 2007, Ivan Kalvachev wrote: >>> >>>> I had a discussion with Johannes Schindelin over my patch, that I >>>> thought is on the maillist, but apparently it wasn't. I'm >>>> subscribed, so please don't send me mails directly, gmail web >>>> interface could be quite misleading. >>>> >>>> So here is the third revision of my patch. Changes include: using >>>> more structures instead of fixed byte locations. chs and nt_id. more >>>> detailed comments, function name shortened and if(lba) moved to ?: >>>> construct. >>> Almost all my comments went unheeded. >> I believe that I've answered and addressed all your comments. > > Ooops. I think I mixed up your patch with the other patch for vvfat that > floated around recently. (Probably because the patch was not inlined...) > > FWIW if we're talking about qemu_vvfat_mbr_v3.patch, I have no more > gripes. > > Thanks, > Dscho > > > I think you were referring to the small patch I sent. I actually gave up with it, as I don't see how to make it in a clean way. Honestly I found your suggestion to try to have it less special-casing vvfat a bit puzzling... vvfat is the only case in which there's any need to override realpath() behaviour, so I tried to make it as clear as possible. Why is it better to affect code paths which don't need any change? Regards, Lorenzo