From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IaZ7a-0000Ut-Cs for qemu-devel@nongnu.org; Wed, 26 Sep 2007 11:48:18 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IaZ7X-0000S1-GP for qemu-devel@nongnu.org; Wed, 26 Sep 2007 11:48:18 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IaZ7X-0000Rg-AU for qemu-devel@nongnu.org; Wed, 26 Sep 2007 11:48:15 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IaZ7V-0001NQ-Sy for qemu-devel@nongnu.org; Wed, 26 Sep 2007 11:48:14 -0400 Message-ID: <46FA7F08.4070109@bull.net> Date: Wed, 26 Sep 2007 17:47:20 +0200 From: Laurent Vivier MIME-Version: 1.0 References: In-Reply-To: Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigDB935BBE3A8155A48F67D8A7" Subject: [Qemu-devel] Re: [kvm-devel] [ kvm-Bugs-1802223 ] nics have same hw address (rtl8139) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: kvm-devel@lists.sourceforge.net Cc: qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigDB935BBE3A8155A48F67D8A7 Content-Type: multipart/mixed; boundary="------------010308020206000106090004" This is a multi-part message in MIME format. --------------010308020206000106090004 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Hi, I think there is a bug in qemu RTL8139. RTL8139 uses: cpu_register_physical_memory(addr + 0, 0x100, s->rtl8139_mmio_io_addr); But in the comment of cpu_register_physical_memory() we have: "'size' must be a multiple of the target page size." And I think 0x100 is not a multiple of target page size.... :-P The attached patch corrects the problem. Laurent SourceForge.net wrote: > Bugs item #1802223, was opened at 2007-09-25 22:59 > Message generated for change (Tracker Item Submitted) made by Item Subm= itter > You can respond by visiting:=20 > https://sourceforge.net/tracker/?func=3Ddetail&atid=3D893831&aid=3D1802= 223&group_id=3D180599 >=20 > Please note that this message will contain a full copy of the comment t= hread, > including the initial issue submission, for this request, > not just the latest update. > Category: None > Group: None > Status: Open > Resolution: None > Priority: 5 > Private: No > Submitted By: xeb (xebd) > Assigned to: Nobody/Anonymous (nobody) > Summary: nics have same hw address (rtl8139) >=20 > Initial Comment: > Hello! >=20 > Host:Linux 2.6.22-gentoo-r2 #2 SMP Fri Aug 3 07:01:46 MSD 2007 x86_64 A= MD Athlon(tm) 64 X2 Dual Core Processor 5600+ AuthenticAMD GNU/Linux,Gent= oo, kvm-44 >=20 > Guest:Linux 2.6.22-hardened-r4 >=20 > command line: > qemu-system-x86_64 -hda server_base_x86.img -hdc server_swap.img -local= time -m 128 \ > -net nic,vlan=3D0,macaddr=3D52:54:00:12:34:56,model=3Drtl8139 -net = tap,vlan=3D0,ifname=3Dtap3,script=3Dno \ > -net nic,vlan=3D1,macaddr=3D52:54:00:12:34:57,model=3Drtl8139 -net = tap,vlan=3D1,ifname=3Dtap4,script=3Dno \ > -net nic,vlan=3D2,macaddr=3D52:54:00:12:34:58,model=3Drtl8139 -net = tap,vlan=3D2,ifname=3Dtap5,script=3Dno \ > -nographic >=20 > ifconfig on guest: > eth0 Link encap:Ethernet HWaddr 52:54:00:12:34:58 > UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 > RX packets:0 errors:0 dropped:0 overruns:0 frame:0 > TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 > collisions:0 txqueuelen:1000 > RX bytes:0 (0.0 b) TX bytes:0 (0.0 b) > Interrupt:11 Base address:0x4000 >=20 > eth1 Link encap:Ethernet HWaddr 52:54:00:12:34:58 > inet addr:192.168.11.1 Bcast:192.168.11.255 Mask:255.255.25= 5.0 > UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 > RX packets:0 errors:0 dropped:0 overruns:0 frame:0 > TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 > collisions:0 txqueuelen:1000 > RX bytes:0 (0.0 b) TX bytes:0 (0.0 b) > Interrupt:9 Base address:0x6100 >=20 > eth2 Link encap:Ethernet HWaddr 52:54:00:12:34:58 > inet addr:192.168.13.1 Bcast:192.168.13.255 Mask:255.255.25= 5.0 > UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 > RX packets:0 errors:0 dropped:0 overruns:0 frame:0 > TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 > collisions:0 txqueuelen:1000 > RX bytes:0 (0.0 b) TX bytes:0 (0.0 b) > Interrupt:11 Base address:0x8200 >=20 > As can you see they have same hwaddr. > With model=3Dne2k_pci nics have correct hw addresses=20 Laurent --=20 ------------- Laurent.Vivier@bull.net -------------- "Software is hard" - Donald Knuth --------------010308020206000106090004 Content-Type: application/mbox; name="rtl8139.patch" Content-Transfer-Encoding: base64 Content-Disposition: inline; filename="rtl8139.patch" ZGlmZiAtLWdpdCBhL3FlbXUvaHcvcnRsODEzOS5jIGIvcWVtdS9ody9ydGw4MTM5LmMKaW5k ZXggOTRmYzJmYy4uZTM0NTg4OCAxMDA2NDQKLS0tIGEvcWVtdS9ody9ydGw4MTM5LmMKKysr IGIvcWVtdS9ody9ydGw4MTM5LmMKQEAgLTQwOCw2ICs0MDgsOCBAQCB0eXBlZGVmIHN0cnVj dCBSVEw4MTM5VGFsbHlDb3VudGVycwogICAgIHVpbnQxNl90ICAgVHhVbmRybjsKIH0gUlRM ODEzOVRhbGx5Q291bnRlcnM7CiAKKyNkZWZpbmUgUlRMODEzOV9QTlBOTUlPX1NJWkUJMHgx MDAwCisKIC8qIENsZWFycyBhbGwgdGFsbHkgY291bnRlcnMgKi8KIHN0YXRpYyB2b2lkIFJU TDgxMzlUYWxseUNvdW50ZXJzX2NsZWFyKFJUTDgxMzlUYWxseUNvdW50ZXJzKiBjb3VudGVy cyk7CiAKQEAgLTMzMjUsNyArMzMyNyw3IEBAIHN0YXRpYyB2b2lkIHJ0bDgxMzlfbW1pb19t YXAoUENJRGV2aWNlICpwY2lfZGV2LCBpbnQgcmVnaW9uX251bSwKICAgICBQQ0lSVEw4MTM5 U3RhdGUgKmQgPSAoUENJUlRMODEzOVN0YXRlICopcGNpX2RldjsKICAgICBSVEw4MTM5U3Rh dGUgKnMgPSAmZC0+cnRsODEzOTsKIAotICAgIGNwdV9yZWdpc3Rlcl9waHlzaWNhbF9tZW1v cnkoYWRkciArIDAsIDB4MTAwLCBzLT5ydGw4MTM5X21taW9faW9fYWRkcik7CisgICAgY3B1 X3JlZ2lzdGVyX3BoeXNpY2FsX21lbW9yeShhZGRyICsgMCwgUlRMODEzOV9QTlBOTUlPX1NJ WkUsIHMtPnJ0bDgxMzlfbW1pb19pb19hZGRyKTsKIH0KIAogc3RhdGljIHZvaWQgcnRsODEz OV9pb3BvcnRfbWFwKFBDSURldmljZSAqcGNpX2RldiwgaW50IHJlZ2lvbl9udW0sIApAQCAt MzQzOCwxMCArMzQ0MCwxMCBAQCB2b2lkIHBjaV9ydGw4MTM5X2luaXQoUENJQnVzICpidXMs IE5JQ0luZm8gKm5kLCBpbnQgZGV2Zm4pCiAgICAgcy0+cnRsODEzOV9tbWlvX2lvX2FkZHIg PQogICAgIGNwdV9yZWdpc3Rlcl9pb19tZW1vcnkoMCwgcnRsODEzOV9tbWlvX3JlYWQsIHJ0 bDgxMzlfbW1pb193cml0ZSwgcyk7CiAKLSAgICBwY2lfcmVnaXN0ZXJfaW9fcmVnaW9uKCZk LT5kZXYsIDAsIDB4MTAwLCAKKyAgICBwY2lfcmVnaXN0ZXJfaW9fcmVnaW9uKCZkLT5kZXYs IDAsIFJUTDgxMzlfUE5QTk1JT19TSVpFLCAKICAgICAgICAgICAgICAgICAgICAgICAgICAg IFBDSV9BRERSRVNTX1NQQUNFX0lPLCAgcnRsODEzOV9pb3BvcnRfbWFwKTsKIAotICAgIHBj aV9yZWdpc3Rlcl9pb19yZWdpb24oJmQtPmRldiwgMSwgMHgxMDAsIAorICAgIHBjaV9yZWdp c3Rlcl9pb19yZWdpb24oJmQtPmRldiwgMSwgUlRMODEzOV9QTlBOTUlPX1NJWkUsIAogICAg ICAgICAgICAgICAgICAgICAgICAgICAgUENJX0FERFJFU1NfU1BBQ0VfTUVNLCBydGw4MTM5 X21taW9fbWFwKTsKIAogICAgIHMtPmlycSA9IDE2OyAvKiBQQ0kgaW50ZXJydXB0ICovCg== --------------010308020206000106090004-- --------------enigDB935BBE3A8155A48F67D8A7 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFG+n8M9Kffa9pFVzwRAkZzAJ95inbPIu6AjZlKxPEJzajaoHff+ACfUz4X 8/keWEagdD7TQqxmAMon/SA= =sYtI -----END PGP SIGNATURE----- --------------enigDB935BBE3A8155A48F67D8A7--