From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IaZLV-0004ga-HW for qemu-devel@nongnu.org; Wed, 26 Sep 2007 12:02:41 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IaZLT-0004fx-Im for qemu-devel@nongnu.org; Wed, 26 Sep 2007 12:02:40 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IaZLT-0004fo-DN for qemu-devel@nongnu.org; Wed, 26 Sep 2007 12:02:39 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IaZLS-0004P9-CC for qemu-devel@nongnu.org; Wed, 26 Sep 2007 12:02:39 -0400 Message-ID: <46FA828D.1080303@bull.net> Date: Wed, 26 Sep 2007 18:02:21 +0200 From: Laurent Vivier MIME-Version: 1.0 References: <46FA7F08.4070109@bull.net> <20070926155531.GB29729@redhat.com> In-Reply-To: <20070926155531.GB29729@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig27C85F2C83BB3120ADCF42F6" Subject: [Qemu-devel] Re: [kvm-devel] [ kvm-Bugs-1802223 ] nics have same hw address (rtl8139) Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig27C85F2C83BB3120ADCF42F6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Daniel P. Berrange wrote: > On Wed, Sep 26, 2007 at 05:47:20PM +0200, Laurent Vivier wrote: >> Hi, >> >> I think there is a bug in qemu RTL8139. >> >> RTL8139 uses: >> >> cpu_register_physical_memory(addr + 0, 0x100, s->rtl8139_mmio_io_addr)= ; >> >> But in the comment of cpu_register_physical_memory() we have: >> >> "'size' must be a multiple of the target page size." >> >> And I think 0x100 is not a multiple of target page size.... :-P >=20 > Latest upstream QEMU has fixed its memory handling so that MMIO regions= > do not need to be a multiple of page size. Changing RTL8139 to use a > block of size 0x1000 is a reasonable short term hack around the problem= , > but syncing with latest QEMU is the real solution, since there are othe= r > places in the code which will have similar issues. >=20 So this explains why rtl8139.c from QEMU CVS always uses 0x100. Thank you for the comment. Avi, you know what you have to do ;-) Laurent --=20 ------------- Laurent.Vivier@bull.net -------------- "Software is hard" - Donald Knuth --------------enig27C85F2C83BB3120ADCF42F6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFG+oKN9Kffa9pFVzwRAvdeAJ9GnpGNw4yO5k1gZY+576q9YgwmGQCfX/Sw sY03Knwb7Y4c8YBgoqBsoWA= =aZ8O -----END PGP SIGNATURE----- --------------enig27C85F2C83BB3120ADCF42F6--