From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Akihiko Odaki" <akihiko.odaki@daynix.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>,
"Thomas Huth" <thuth@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Dmitry Fleytman" <dmitry.fleytman@gmail.com>,
"Phil Dennis-Jordan" <phil@philjordan.eu>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH v3 0/4] ui/cocoa: Add cursor composition
Date: Tue, 16 Jul 2024 19:55:30 +0200 [thread overview]
Message-ID: <46cb3e8d-c20f-440c-b5e1-0ed3d67fdf70@linaro.org> (raw)
In-Reply-To: <20240715-cursor-v3-0-afa5b9492dbf@daynix.com>
On 15/7/24 07:25, Akihiko Odaki wrote:
> Add accelerated cursor composition to ui/cocoa. This does not only
> improve performance for display devices that exposes the capability to
> the guest according to dpy_cursor_define_supported(), but fixes the
> cursor display for devices that unconditionally expects the availability
> of the capability (e.g., virtio-gpu).
>
> The common pattern to implement accelerated cursor composition is to
> replace the cursor and warp it so that the replaced cursor is shown at
> the correct position on the guest display for relative pointer devices.
> Unfortunately, ui/cocoa cannot do the same because warping the cursor
> position interfers with the mouse input so it uses CALayer instead;
> although it is not specialized for cursor composition, it still can
> compose images with hardware acceleration.
> Akihiko Odaki (4):
> ui/cocoa: Release CGColorSpace
> ui/console: Convert mouse visibility parameter into bool
> ui/cocoa: Add cursor composition
> ui/console: Remove dpy_cursor_define_supported()
No issue with rudimentary testing, so series queued, thanks!
prev parent reply other threads:[~2024-07-16 17:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-15 5:25 [PATCH v3 0/4] ui/cocoa: Add cursor composition Akihiko Odaki
2024-07-15 5:25 ` [PATCH v3 1/4] ui/cocoa: Release CGColorSpace Akihiko Odaki
2024-07-15 6:57 ` Philippe Mathieu-Daudé
2024-07-15 5:25 ` [PATCH v3 2/4] ui/console: Convert mouse visibility parameter into bool Akihiko Odaki
2024-07-15 6:56 ` Philippe Mathieu-Daudé
2024-07-15 5:25 ` [PATCH v3 3/4] ui/cocoa: Add cursor composition Akihiko Odaki
2024-07-15 5:25 ` [PATCH v3 4/4] ui/console: Remove dpy_cursor_define_supported() Akihiko Odaki
2024-07-16 17:55 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46cb3e8d-c20f-440c-b5e1-0ed3d67fdf70@linaro.org \
--to=philmd@linaro.org \
--cc=akihiko.odaki@daynix.com \
--cc=berrange@redhat.com \
--cc=dmitry.fleytman@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=phil@philjordan.eu \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).