From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1DvGSO-00033f-M6 for qemu-devel@nongnu.org; Wed, 20 Jul 2005 11:26:00 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1DvGSJ-00031n-Uz for qemu-devel@nongnu.org; Wed, 20 Jul 2005 11:25:56 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1DvGSJ-0002zw-Rr for qemu-devel@nongnu.org; Wed, 20 Jul 2005 11:25:55 -0400 Received: from [64.233.182.205] (helo=nproxy.gmail.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1DvGV7-00067E-Cz for qemu-devel@nongnu.org; Wed, 20 Jul 2005 11:28:49 -0400 Received: by nproxy.gmail.com with SMTP id n15so399865nfc for ; Wed, 20 Jul 2005 08:19:04 -0700 (PDT) Message-ID: <46d6db6605072008197166ffbb@mail.gmail.com> Date: Wed, 20 Jul 2005 17:19:04 +0200 From: Christian MICHON Subject: Re: [Qemu-devel] Can you commit the pcnet patch ? In-Reply-To: <46d6db6605072007454a2024d0@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Content-Disposition: inline References: <42DE282A.3080102@linbox.com> <200507201337.12953.paul@codesourcery.com> <42DE49E1.9010405@linbox.com> <46d6db660507200726387f3f6d@mail.gmail.com> <46d6db6605072007454a2024d0@mail.gmail.com> Reply-To: Christian MICHON , qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org When I try to replace bcmp (inexistant in mingw32) with memcmp inside pcnet.h, like this: int result =3D (!CSR_DRCVPA(s)) && !bcmp(hdr->ether_dhost, padr, 6); into=20 int result =3D (!CSR_DRCVPA(s)) && !bcmp(hdr->ether_dhost, padr, 6); I get the following error: In file included from C:/dev/msys/1.0/home/xian/qemu-0.7.0/hw/pcnet.c:64: C:/dev/msys/1.0/home/xian/qemu-0.7.0/hw/pcnet.h: In function `padr_match': C:/dev/msys/1.0/home/xian/qemu-0.7.0/hw/pcnet.h:531: error: dereferencing pointer to incomplete type anyone having a fix. I'm quite puzzled by the gcc error message. Thx Christian =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D static inline int padr_match(PCNetState *s, const uint8_t *buf, int size) { struct ether_header *hdr =3D (void *)buf; uint8_t padr[6] =3D {=20 s->csr[12] & 0xff, s->csr[12] >> 8, s->csr[13] & 0xff, s->csr[13] >> 8, s->csr[14] & 0xff, s->csr[14] >> 8=20 }; int result =3D (!CSR_DRCVPA(s)) && !memcmp(hdr->ether_dhost, padr, 6); for better understanding of the faulty piece of code