From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IMBXv-00019B-PQ for qemu-devel@nongnu.org; Fri, 17 Aug 2007 19:48:03 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IMBXv-00016C-0e for qemu-devel@nongnu.org; Fri, 17 Aug 2007 19:48:03 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IMBXu-00015l-TI for qemu-devel@nongnu.org; Fri, 17 Aug 2007 19:48:02 -0400 Received: from wa-out-1112.google.com ([209.85.146.182]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IMBXu-0003tw-Ga for qemu-devel@nongnu.org; Fri, 17 Aug 2007 19:48:02 -0400 Received: by wa-out-1112.google.com with SMTP id l35so7799waf for ; Fri, 17 Aug 2007 16:48:01 -0700 (PDT) Message-ID: <46d6db660708171648m3a798685q6514261bc097bc62@mail.gmail.com> Date: Sat, 18 Aug 2007 01:48:01 +0200 From: "Christian MICHON" Subject: Re: [Qemu-devel] [PATCH 0/4] Rework alarm timer infrastrucure - take 2 In-Reply-To: <20070817231149.544849769@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <20070817231149.544849769@gmail.com> Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: kvm-devel@lists.sf.net On 8/18/07, Luca Tettamanti wrote: > Hello, > in reply to this mail I will send a serie of 4 patches that cleans up and > expands the alarm timer handling in QEMU. Patches have been rebased on QEMU > CVS. > > Patch 1 is mostly a cleanup of the existing code; instead of having multiple > #ifdefs to handle different timers scattered all over the code I've created a > modular infrastructure where each timer type is self-contained and generic code > is more readable. The resulting code is functionally equivalent to the old one. > > Patch 2 implements the "-clock" command line option proposed by Daniel Berrange > and Avi Kivity. By default QEMU tries RTC and then falls back to unix timer; > user can override the order of the timer through this options. Syntax is pretty > simple: -clock timer1,timer2,etc. (QEMU will pick the first one that works). > > Patch 3 adds support for HPET under Linux (which is basically my old patch). As > suggested HPET takes precedence over other timers, but of course this can be > overridden. > > Patch 4 introduces "dynticks" timer source; patch is mostly based on the work > Dan Kenigsberg. dynticks is now the default alarm timer. > > Luca > -- > > > there's a typo line 1432 on vl.c after applying all 4 patches (missing ';') C:/msys/1.0/home/Xian/qemu/vl.c: In function `win32_start_timer': C:/msys/1.0/home/Xian/qemu/vl.c:1432: error: syntax error before '}' token make[1]: *** [vl.o] Error 1 beyond this small typo, I managed to include this in a win32 qemu build. is there a specific practical test to see the improvement in a linux guest when running on a windows host ? -- Christian -- http://detaolb.sourceforge.net/, a linux distribution for Qemu