From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60416) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUYut-0000UE-No for qemu-devel@nongnu.org; Tue, 02 Aug 2016 08:35:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bUYuo-0007ye-VH for qemu-devel@nongnu.org; Tue, 02 Aug 2016 08:35:27 -0400 Received: from greensocs.com ([193.104.36.180]:44496) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bUYuo-0007yK-KM for qemu-devel@nongnu.org; Tue, 02 Aug 2016 08:35:22 -0400 References: <1465835259-21449-1-git-send-email-fred.konrad@greensocs.com> <1465835259-21449-11-git-send-email-fred.konrad@greensocs.com> From: KONRAD Frederic Message-ID: <46ee34eb-1e9e-ec0a-be1d-8534d17921fe@greensocs.com> Date: Tue, 2 Aug 2016 14:36:05 +0200 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [RFC PATCH 10/11] zynqmp: add the zynqmp_crf to the platform List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Alistair Francis Cc: "qemu-devel@nongnu.org Developers" , Edgar Iglesias , Peter Maydell , Mark Burton Le 02/07/2016 =C3=A0 01:11, Alistair Francis a =C3=A9crit : > On Mon, Jun 13, 2016 at 9:27 AM, wrote: >> From: KONRAD Frederic >> >> This adds the zynqmp_crf to the zynqmp platform. >> >> Signed-off-by: KONRAD Frederic >> --- >> hw/arm/xlnx-zynqmp.c | 7 +++++++ >> include/hw/arm/xlnx-zynqmp.h | 1 + >> 2 files changed, 8 insertions(+) >> >> diff --git a/hw/arm/xlnx-zynqmp.c b/hw/arm/xlnx-zynqmp.c >> index 4d504da..a8b7669 100644 >> --- a/hw/arm/xlnx-zynqmp.c >> +++ b/hw/arm/xlnx-zynqmp.c >> @@ -135,6 +135,11 @@ static void xlnx_zynqmp_init(Object *obj) >> TYPE_XILINX_SPIPS); >> qdev_set_parent_bus(DEVICE(&s->spi[i]), sysbus_get_default()= ); >> } >> + >> + s->crf =3D object_new("xlnx.zynqmp_crf"); >> + qdev_set_parent_bus(DEVICE(s->crf), sysbus_get_default()); >> + object_property_add_child(obj, "xlnx.zynqmp_crf", OBJECT(s->crf), >> + &error_abort); >> } >> >> static void xlnx_zynqmp_realize(DeviceState *dev, Error **errp) >> @@ -366,6 +371,8 @@ static void xlnx_zynqmp_realize(DeviceState *dev, = Error **errp) >> &error_abort); >> g_free(bus_name); >> } >> + >> + sysbus_mmio_map(SYS_BUS_DEVICE(s->crf), 0, 0xFD1A0000); > Shouldn't this be realised? > > Also macro for the address. > >> } >> >> static Property xlnx_zynqmp_props[] =3D { >> diff --git a/include/hw/arm/xlnx-zynqmp.h b/include/hw/arm/xlnx-zynqmp= .h >> index 2332596..78fed6e 100644 >> --- a/include/hw/arm/xlnx-zynqmp.h >> +++ b/include/hw/arm/xlnx-zynqmp.h >> @@ -81,6 +81,7 @@ typedef struct XlnxZynqMPState { >> SysbusAHCIState sata; >> SDHCIState sdhci[XLNX_ZYNQMP_NUM_SDHCI]; >> XilinxSPIPS spi[XLNX_ZYNQMP_NUM_SPIS]; >> + Object *crf; > Can we follow the same way as the other devices? Yes I can do that. > > You'll need to split a header file out for the device then. > > Thanks, > > Alistair > >> char *boot_cpu; >> ARMCPU *boot_cpu_ptr; >> -- >> 2.5.5 >> >>