From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.1 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BCF70C4338F for ; Thu, 12 Aug 2021 04:46:53 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 297CC60551 for ; Thu, 12 Aug 2021 04:46:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 297CC60551 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mE2cF-0004CQ-VO for qemu-devel@archiver.kernel.org; Thu, 12 Aug 2021 00:46:51 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:50218) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mE2b9-0003SB-UU for qemu-devel@nongnu.org; Thu, 12 Aug 2021 00:45:43 -0400 Received: from mail-pl1-x634.google.com ([2607:f8b0:4864:20::634]:33458) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1mE2b8-0003jL-IP for qemu-devel@nongnu.org; Thu, 12 Aug 2021 00:45:43 -0400 Received: by mail-pl1-x634.google.com with SMTP id a20so5707074plm.0 for ; Wed, 11 Aug 2021 21:45:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=k+2mA4Q36RTWJ5sfpI0V9+OLbAzxCLS7/EZ+WUAG54g=; b=QKz8gnzvE2gvisW4+fl3JWUpGcwLAYH3guGNXfT4i9hy+cvdYsoQHClToKH48x5v6n HKnmTxpZznjDTVACItAEV9XhV9h6BEzuZCaXe3j9I9fqDpx9C2JaJdONOGRdmpgtnjOz /RnFOMK87abhCi48aqgYWRixfJAUjKc0x0pCi7d1KbGW2Mp1b5jUr0gp8k+Bw17youVY poGH2cz+4i3MQ7eN3iZ4SlboFy8p27c7gzvRWH3Hk0pW6P6nrxAAuAEwnzx8VC0UuJEe HUld5uPN7nX59Hok/Kbvp1tzOIkdnT2ollYggffmnOhXnBNzOQVozTQ4b4LNhRAh0sa6 v7VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=k+2mA4Q36RTWJ5sfpI0V9+OLbAzxCLS7/EZ+WUAG54g=; b=FpxGbrKKJ2746BFr7Qjm6bz4Vnp8OKv3ldRYP+dffmY/LwloOqeXeYhDBYUxbgZifj P13r3d+XW1FYZ9jvFEf6J5nUKqvDTYdgS3VV8pBw9pPr66Rf1Iotdh1c0btHMhsP0Tyl oZ1UJXMCgQdho4yNsrL3em43woV7Z4qNFVE4XnPiZprBn8K5nRf/pp7/zqPf10mTQTA6 WD9zizf2lXiA/9B+ff9dDLKH9nZ65QxQckhnDtBcofWcyBxLVljdXYVXFChrXWI5Ra/y tLlWxkWN7zj9r1R95L9OKKkMbjutCJun2qC5I3MUIUYDjagZj3Yfx17l4asiZq/p2rum BBLA== X-Gm-Message-State: AOAM531DcXZQNLnnFFdeXsJ72EBLQwNQGa/Q9Gp0w5BBRKtGGl+NHAtw wfNF7dauLrm0hr/r7AEOU2ihAA== X-Google-Smtp-Source: ABdhPJwqhAlPA6CFewdNz2O8LgHH+yy4hB492ZKi6QMkUyzkphyfeO2NqMtzuw/7vpkHep+qikCMPA== X-Received: by 2002:a05:6a00:22c8:b029:3cd:d4be:e0e0 with SMTP id f8-20020a056a0022c8b02903cdd4bee0e0mr2316717pfj.43.1628743540858; Wed, 11 Aug 2021 21:45:40 -0700 (PDT) Received: from [192.168.6.169] (rrcs-173-198-77-218.west.biz.rr.com. [173.198.77.218]) by smtp.gmail.com with ESMTPSA id o22sm1306170pfu.87.2021.08.11.21.45.38 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 11 Aug 2021 21:45:39 -0700 (PDT) Subject: Re: [PATCH 12/19] target/ppc/pmu_book3s_helper.c: enable PMC1 counter negative EBB To: David Gibson , Daniel Henrique Barboza References: <20210809131057.1694145-1-danielhb413@gmail.com> <20210809131057.1694145-13-danielhb413@gmail.com> <6a10c0a7-1c4f-0d24-f2cc-12666e590739@gmail.com> <4df4dacf-ba9b-f86e-8510-7c084420e974@gmail.com> From: Richard Henderson Message-ID: <47018114-2249-0fe9-cb87-0ac35ed1e49d@linaro.org> Date: Wed, 11 Aug 2021 18:45:36 -1000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=2607:f8b0:4864:20::634; envelope-from=richard.henderson@linaro.org; helo=mail-pl1-x634.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, gustavo.romero@linaro.org, clg@kaod.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On 8/11/21 5:39 PM, David Gibson wrote: >> I mean, nothing is stopping us from calculating cycles using time, but in the >> end we would do the same thing we're already doing today. > > Oh.. ok. I had assumed that icount worked by instrumenting the > generate TCG code to actually count instructions, rather than working > off the time. David, you're right, icount instruments the generated tcg code. You also have to add -icount to the command-line. r~