[Qemu-devel] [RFC] CRIS target port

[Qemu-devel] [RFC] CRIS target port

[Edgar E. Iglesias]

Hello,

I've been working an a CRISv32 target port of Qemu. The linux-user emulation is quite functional but the system emulation is still very limited.

I've tested the user emulation with a test-suite added to the tests/ dir in Qemu. I also used GCC's c torture tests from the CRIS GCC port based on GCC 3.2.1.

I'm publishing the patches for review, all kinds of comments are appreciated.
I would also like to know if there are any formalities I need to consider in case this would get committed, like copyright assignments and so on.

The patches are quite large so I put them on our ftp server:
ftp://ftp.axis.com/pub/users/edgar/

If someone prefers patches in another form or access to my git repository, let me know and I'll be happy to provide that.

More info on the CRIS core and the ETRAX SoC's can be found here:
http://en.wikipedia.org/wiki/ETRAX_CRIS

Thank you and best regards
-- 
Edgar E. Iglesias
Axis Communications AB

Re: [Qemu-devel] [RFC] CRIS target port

[Johannes Schindelin]

Hi,

On Tue, 2 Oct 2007, Edgar E. Iglesias wrote:

> If someone prefers patches in another form or access to my git 
> repository, let me know and I'll be happy to provide that.

Why not add a fork on http://repo.or.cz/w/qemu.git/?  It's easy: just 
click on the "fork" link, fill out a small form, and add yourself as user.

If you do not have a user account on repo.or.cz yet, you'll have to 
register one, which is as easy as typing your email address and uploading 
an ssh public key.

Ciao,
Dscho

Re: [Qemu-devel] [RFC] CRIS target port

[Edgar E. Iglesias]

On Tue, Oct 02, 2007 at 01:02:23PM +0100, Johannes Schindelin wrote:
> Hi,
> 
> On Tue, 2 Oct 2007, Edgar E. Iglesias wrote:
> 
> > If someone prefers patches in another form or access to my git 
> > repository, let me know and I'll be happy to provide that.
> 
> Why not add a fork on http://repo.or.cz/w/qemu.git/?  It's easy: just 
> click on the "fork" link, fill out a small form, and add yourself as user.
> 
> If you do not have a user account on repo.or.cz yet, you'll have to 
> register one, which is as easy as typing your email address and uploading 
> an ssh public key.

Thanks Johannes,

Description	CRIS target port of Qemu
Owner	edgar.iglesias@axis.com
Mirror URL	git://repo.or.cz/qemu/cris-port.git
	        http://repo.or.cz/r/qemu/cris-port.git
Push URL	git+ssh://repo.or.cz/srv/git/qemu/cris-port.git

Best regards
-- 
Edgar E. Iglesias
Axis Communications AB

merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Bernhard Fischer]

On Tue, Oct 02, 2007 at 01:02:23PM +0100, Johannes Schindelin wrote:
>Hi,
>
>On Tue, 2 Oct 2007, Edgar E. Iglesias wrote:
>
>> If someone prefers patches in another form or access to my git 
>> repository, let me know and I'll be happy to provide that.
>
>Why not add a fork on http://repo.or.cz/w/qemu.git/?  It's easy: just 

Ah, very nice.
Would anybody be willing to apply the ggi-display into this on behalf of me?

http://uclibc.org/~aldot/qemu/

has my working copy against cvs from a few days ago.. The code is
the same as from 2004/2005, just rediffed the hunks against the configure
script a year ago.

>click on the "fork" link, fill out a small form, and add yourself as user.

Well, ideally i'd like to see the GGI support living directly in
the upstream repo.
If i need to make changes to get it accepted, please let me know.

thanks and cheers,
Bernhard

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Johannes Schindelin]

Hi,

On Tue, 2 Oct 2007, Bernhard Fischer wrote:

> On Tue, Oct 02, 2007 at 01:02:23PM +0100, Johannes Schindelin wrote:
>
> >On Tue, 2 Oct 2007, Edgar E. Iglesias wrote:
> >
> >> If someone prefers patches in another form or access to my git 
> >> repository, let me know and I'll be happy to provide that.
> >
> >Why not add a fork on http://repo.or.cz/w/qemu.git/?  It's easy: just 
> 
> Ah, very nice. Would anybody be willing to apply the ggi-display into 
> this on behalf of me?
> 
> http://uclibc.org/~aldot/qemu/
> 
> has my working copy against cvs from a few days ago.. The code is the 
> same as from 2004/2005, just rediffed the hunks against the configure 
> script a year ago.

Done.

FWIW I would have preferred you following my simple instructions to set up 
a fork, but what the heck.

Anybody who fetches the "ggi" branch from my repository on repo.or.cz: 
this branch will be rebased.  You have been warned.

> >click on the "fork" link, fill out a small form, and add yourself as user.
> 
> Well, ideally i'd like to see the GGI support living directly in the 
> upstream repo. If i need to make changes to get it accepted, please let 
> me know.

AFAIR there were license issues with GGI, which made that unfeasible.

Ciao,
Dscho

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Bernhard Fischer]

On Tue, Oct 02, 2007 at 06:32:20PM +0100, Johannes Schindelin wrote:
>Hi,

>FWIW I would have preferred you following my simple instructions to set up 
>a fork, but what the heck.

ermz, sorry. Thanks :)
>
>Anybody who fetches the "ggi" branch from my repository on repo.or.cz: 
>this branch will be rebased.  You have been warned.
>
>> >click on the "fork" link, fill out a small form, and add yourself as user.
>> 
>> Well, ideally i'd like to see the GGI support living directly in the 
>> upstream repo. If i need to make changes to get it accepted, please let 
>> me know.
>
>AFAIR there were license issues with GGI, which made that unfeasible.

GGI itself is under the MIT license. IIRC I initially put the qemu-ggi
support under BSD. If this is somehow too strict or not appropriate for
it being accepted, then i'm very willing to dual license it BSD/GPL if
that would help.

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Thiemo Seufer]

Bernhard Fischer wrote:
> On Tue, Oct 02, 2007 at 01:02:23PM +0100, Johannes Schindelin wrote:
> >Hi,
> >
> >On Tue, 2 Oct 2007, Edgar E. Iglesias wrote:
> >
> >> If someone prefers patches in another form or access to my git 
> >> repository, let me know and I'll be happy to provide that.
> >
> >Why not add a fork on http://repo.or.cz/w/qemu.git/?  It's easy: just 
> 
> Ah, very nice.
> Would anybody be willing to apply the ggi-display into this on behalf of me?
> 
> http://uclibc.org/~aldot/qemu/
> 
> has my working copy against cvs from a few days ago.. The code is
> the same as from 2004/2005, just rediffed the hunks against the configure
> script a year ago.
> 
> >click on the "fork" link, fill out a small form, and add yourself as user.
> 
> Well, ideally i'd like to see the GGI support living directly in
> the upstream repo.
> If i need to make changes to get it accepted, please let me know.

- The have_gcc3_options addition to configure looks suspicious.
- The softfloat.h/system.h workaround should be conditional on softfloat
  use (or, preferably, by cleaning up the GGI namespace pollution).
- What is the deal with the GGI license mentioned?


Thiemo

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Bernhard Fischer]

On Tue, Oct 02, 2007 at 07:36:47PM +0100, Thiemo Seufer wrote:
>Bernhard Fischer wrote:

>> If i need to make changes to get it accepted, please let me know.
>
>- The have_gcc3_options addition to configure looks suspicious.

Looks like a leftover, yes. Removed.

>- The softfloat.h/system.h workaround should be conditional on softfloat
>  use (or, preferably, by cleaning up the GGI namespace pollution).

IIRC we already did that on trunk, yes.

>- What is the deal with the GGI license mentioned?

I don't really know. The current patch has
+/* #include license.bsd */
But if this imposes a problem due to the advertising clause, it's fine
with me to dual-license it BSD/GPL (or just GPL for that matter).

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Bernhard Fischer]

On Tue, Oct 02, 2007 at 09:29:51PM +0200, Bernhard Fischer wrote:
>On Tue, Oct 02, 2007 at 07:36:47PM +0100, Thiemo Seufer wrote:

>>- What is the deal with the GGI license mentioned?
>
>I don't really know. The current patch has
>+/* #include license.bsd */
>But if this imposes a problem due to the advertising clause, it's fine
>with me to dual-license it BSD/GPL (or just GPL for that matter).

I just looked again and there is no issue that i can see.
QEMU as a whole is licensed under GPL, libqemu may be LGPL.
Several parts of devices are under BSD (if used standalone, outside
qemu, it seems).

I've expanded the brief '#include license.bsd' by the whole blob with a
note that

 * alternatively
 * you can redistribute it and/or modify
 * it under the terms of the GNU General Public License as published by
 * the Free Software Foundation; either version 2 of the License, or
 * (at your option) any later version.
 */

now, so that shouldn't be a real issue, i hope.

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Anthony Liguori]

What does one gain with GGI support?  I've never seen a good answer to this.

Regards,

Anthony Liguori

Bernhard Fischer wrote:
> On Tue, Oct 02, 2007 at 01:02:23PM +0100, Johannes Schindelin wrote:
>   
>> Hi,
>>
>> On Tue, 2 Oct 2007, Edgar E. Iglesias wrote:
>>
>>     
>>> If someone prefers patches in another form or access to my git 
>>> repository, let me know and I'll be happy to provide that.
>>>       
>> Why not add a fork on http://repo.or.cz/w/qemu.git/?  It's easy: just 
>>     
>
> Ah, very nice.
> Would anybody be willing to apply the ggi-display into this on behalf of me?
>
> http://uclibc.org/~aldot/qemu/
>
> has my working copy against cvs from a few days ago.. The code is
> the same as from 2004/2005, just rediffed the hunks against the configure
> script a year ago.
>
>   
>> click on the "fork" link, fill out a small form, and add yourself as user.
>>     
>
> Well, ideally i'd like to see the GGI support living directly in
> the upstream repo.
> If i need to make changes to get it accepted, please let me know.
>
> thanks and cheers,
> Bernhard
>
>
>
>   

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Bernhard Fischer]

On Tue, Oct 02, 2007 at 01:45:39PM -0500, Anthony Liguori wrote:
> What does one gain with GGI support?  I've never seen a good answer to 
> this.

GGI supports a number of display-targets:
http://www.ggi-project.org/targets.html
umong them X11, quartz, directx, fbdev, vgl, vnc, wsfb, libaa,
terminfo, cocoa, etc.

So you can display qemu about everywhere you want.

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Anthony Liguori]

Bernhard Fischer wrote:
> On Tue, Oct 02, 2007 at 01:45:39PM -0500, Anthony Liguori wrote:
>   
>> What does one gain with GGI support?  I've never seen a good answer to 
>> this.
>>     
>
> GGI supports a number of display-targets:
> http://www.ggi-project.org/targets.html
> umong them X11, quartz, directx, fbdev, vgl, vnc, wsfb, libaa,
> terminfo, cocoa, etc.
>   

SDL has a GGI backend.  So you can already use GGI with QEMU.

So, what does it buy to have QEMU use GGI directly?

Regards,

Anthony Liguori

> So you can display qemu about everywhere you want.
>
>
>
>   

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Avi Kivity]

Anthony Liguori wrote:
> Bernhard Fischer wrote:
>> On Tue, Oct 02, 2007 at 01:45:39PM -0500, Anthony Liguori wrote:
>>  
>>> What does one gain with GGI support?  I've never seen a good answer 
>>> to this.
>>>     
>>
>> GGI supports a number of display-targets:
>> http://www.ggi-project.org/targets.html
>> umong them X11, quartz, directx, fbdev, vgl, vnc, wsfb, libaa,
>> terminfo, cocoa, etc.
>>   
>
> SDL has a GGI backend.  So you can already use GGI with QEMU.
>
> So, what does it buy to have QEMU use GGI directly?

Does GGI have an SDL backend?

You're in a maze of standard graphics interfaces, all slightly different.

-- 
Any sufficiently difficult bug is indistinguishable from a feature.

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Anthony Liguori]

Avi Kivity wrote:
> Anthony Liguori wrote:
>> Bernhard Fischer wrote:
>>> On Tue, Oct 02, 2007 at 01:45:39PM -0500, Anthony Liguori wrote:
>>>  
>>>> What does one gain with GGI support?  I've never seen a good answer 
>>>> to this.
>>>>     
>>>
>>> GGI supports a number of display-targets:
>>> http://www.ggi-project.org/targets.html
>>> umong them X11, quartz, directx, fbdev, vgl, vnc, wsfb, libaa,
>>> terminfo, cocoa, etc.
>>>   
>>
>> SDL has a GGI backend.  So you can already use GGI with QEMU.
>>
>> So, what does it buy to have QEMU use GGI directly?
>
> Does GGI have an SDL backend?

I don't know, but I do know that SDL has GGI backend so AFAICT, SDL 
becomes a superset of GGI :-)

Regards,

Anthony Liguori

> You're in a maze of standard graphics interfaces, all slightly different.
>

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Bernhard Fischer]

On Tue, Oct 02, 2007 at 03:09:41PM -0500, Anthony Liguori wrote:
> Bernhard Fischer wrote:
>> On Tue, Oct 02, 2007 at 01:45:39PM -0500, Anthony Liguori wrote:
>>   
>>> What does one gain with GGI support?  I've never seen a good answer to 
>>> this.
>>>     
>>
>> GGI supports a number of display-targets:
>> http://www.ggi-project.org/targets.html
>> umong them X11, quartz, directx, fbdev, vgl, vnc, wsfb, libaa,
>> terminfo, cocoa, etc.
>>   
>
> SDL has a GGI backend.  So you can already use GGI with QEMU.
>
> So, what does it buy to have QEMU use GGI directly?

Well, I don't have SDL. What did it buy to add VNC support and cocoa
support when there was already GGI support and GGI has backends for VNC
and cocoa? ;)

It's not that this patch removes SDL, VNC or cocoa support, really.

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Anthony Liguori]

Bernhard Fischer wrote:
> On Tue, Oct 02, 2007 at 03:09:41PM -0500, Anthony Liguori wrote:
>   
>> Bernhard Fischer wrote:
>>     
>>> On Tue, Oct 02, 2007 at 01:45:39PM -0500, Anthony Liguori wrote:
>>>   
>>>       
>>>> What does one gain with GGI support?  I've never seen a good answer to 
>>>> this.
>>>>     
>>>>         
>>> GGI supports a number of display-targets:
>>> http://www.ggi-project.org/targets.html
>>> umong them X11, quartz, directx, fbdev, vgl, vnc, wsfb, libaa,
>>> terminfo, cocoa, etc.
>>>   
>>>       
>> SDL has a GGI backend.  So you can already use GGI with QEMU.
>>
>> So, what does it buy to have QEMU use GGI directly?
>>     
>
> Well, I don't have SDL. What did it buy to add VNC support and cocoa
> support when there was already GGI support and GGI has backends for VNC
> and cocoa? ;)
>   

I can't comment about cocoa but the GGI support for VNC isn't very 
good.  Plus, I wanted to add new VNC extensions for virtualization.

If the only argument for adding GGI is so that you don't have to install 
libsdl, then does that mean that we should have an X11, fbdev, etc. 
backend for people who don't have GGI installed?

Regards,

Anthony Liguori

> It's not that this patch removes SDL, VNC or cocoa support, really.
>
>
>
>   

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[andrzej zaborowski]

Hi,

On 02/10/2007, Anthony Liguori <anthony@codemonkey.ws> wrote:
> Bernhard Fischer wrote:
> > On Tue, Oct 02, 2007 at 03:09:41PM -0500, Anthony Liguori wrote:
> >
> >> Bernhard Fischer wrote:
> >>
> >>> On Tue, Oct 02, 2007 at 01:45:39PM -0500, Anthony Liguori wrote:
> >>>
> >>>
> >>>> What does one gain with GGI support?  I've never seen a good answer to
> >>>> this.
> >>>>
> >>>>
> >>> GGI supports a number of display-targets:
> >>> http://www.ggi-project.org/targets.html
> >>> umong them X11, quartz, directx, fbdev, vgl, vnc, wsfb, libaa,
> >>> terminfo, cocoa, etc.
> >>>
> >>>
> >> SDL has a GGI backend.  So you can already use GGI with QEMU.
> >>
> >> So, what does it buy to have QEMU use GGI directly?
> >>
> >
> > Well, I don't have SDL. What did it buy to add VNC support and cocoa
> > support when there was already GGI support and GGI has backends for VNC
> > and cocoa? ;)
> >
>
> I can't comment about cocoa but the GGI support for VNC isn't very
> good.  Plus, I wanted to add new VNC extensions for virtualization.

I think it's the same way with other back-ends - you can do more
things if you talk to them directly instead of through SDL.

>
> If the only argument for adding GGI is so that you don't have to install
> libsdl, then does that mean that we should have an X11, fbdev, etc.
> backend for people who don't have GGI installed?

I think a GGI back-end would be useful.

I wouldn't mind also having other back-ends even if SDL supports them
(e.g. there's an Xlib patch for qemu, it is very little code compared
to vnc.c which you could say duplicates code already present in
libraries). The situation is the same with audio backends: there's
oss, alsa and SDL which can do both oss and alsa but works poorly.

Unrelated to this discussion on slow links VNC is much more usable
with the Xlib patch and Xvnc than through the built-in VNC (I think it
makes a better decision on what format to use based on the connection
speed).
Regards,
Andrew

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Anthony Liguori]

andrzej zaborowski wrote:
> Hi,
>
>   
>> If the only argument for adding GGI is so that you don't have to install
>> libsdl, then does that mean that we should have an X11, fbdev, etc.
>> backend for people who don't have GGI installed?
>>     
>
> I think a GGI back-end would be useful.
>
> I wouldn't mind also having other back-ends even if SDL supports them
> (e.g. there's an Xlib patch for qemu, it is very little code compared
> to vnc.c which you could say duplicates code already present in
> libraries). The situation is the same with audio backends: there's
> oss, alsa and SDL which can do both oss and alsa but works poorly.
>
> Unrelated to this discussion on slow links VNC is much more usable
> with the Xlib patch and Xvnc than through the built-in VNC (I think it
> makes a better decision on what format to use based on the connection
> speed).
>   

It's probably just the lack of a compressed encoding.

Regards,

Anthony Liguori

> Regards,
> Andrew
>
>
>
>   

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Daniel P. Berrange]

On Wed, Oct 03, 2007 at 08:59:47AM -0500, Anthony Liguori wrote:
> andrzej zaborowski wrote:
> >Hi,
> >
> >  
> >>If the only argument for adding GGI is so that you don't have to install
> >>libsdl, then does that mean that we should have an X11, fbdev, etc.
> >>backend for people who don't have GGI installed?
> >>    
> >
> >I think a GGI back-end would be useful.
> >
> >I wouldn't mind also having other back-ends even if SDL supports them
> >(e.g. there's an Xlib patch for qemu, it is very little code compared
> >to vnc.c which you could say duplicates code already present in
> >libraries). The situation is the same with audio backends: there's
> >oss, alsa and SDL which can do both oss and alsa but works poorly.
> >
> >Unrelated to this discussion on slow links VNC is much more usable
> >with the Xlib patch and Xvnc than through the built-in VNC (I think it
> >makes a better decision on what format to use based on the connection
> >speed).
> 
> It's probably just the lack of a compressed encoding.

There are various optimizations to the VNC server in QEMU Uthat the
Xen project did in their fork. On my infinite todo list is an note to
take a look at these & see if its worth posting them here for merge.
At least one of the changes was to reduce the number of FB updates 
sent to the client under some circumstances.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Re: merge GGI support? [was: Re: [Qemu-devel] [RFC] CRIS target port]

[Johannes Schindelin]

Hi,

On Tue, 2 Oct 2007, Anthony Liguori wrote:

> What does one gain with GGI support?  I've never seen a good answer to 
> this.

GGI has backends that SDL does not have.

Hth,
Dscho

Re: [Qemu-devel] [RFC] CRIS target port

[Thiemo Seufer]

Edgar E. Iglesias wrote:
> Hello,
> 
> I've been working an a CRISv32 target port of Qemu. The linux-user
> emulation is quite functional but the system emulation is still
> very limited.

Impressive work!

> I've tested the user emulation with a test-suite added to the tests/
> dir in Qemu. I also used GCC's c torture tests from the CRIS GCC
> port based on GCC 3.2.1.
> 
> I'm publishing the patches for review, all kinds of comments are
> appreciated.
> I would also like to know if there are any formalities I need to
> consider in case this would get committed, like copyright assignments
> and so on.

No such formalities are needed.

> The patches are quite large so I put them on our ftp server:
> ftp://ftp.axis.com/pub/users/edgar/

Please split both up in more managable pieces and post them to the
mailing list (for easier review and Google posterity).


Thiemo