From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Ieu1H-00011O-6j
	for qemu-devel@nongnu.org; Mon, 08 Oct 2007 10:55:43 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Ieu1F-00011C-8W
	for qemu-devel@nongnu.org; Mon, 08 Oct 2007 10:55:42 -0400
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Ieu1F-000119-3I
	for qemu-devel@nongnu.org; Mon, 08 Oct 2007 10:55:41 -0400
Received: from el-out-1112.google.com ([209.85.162.181])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1Ieu1E-0002hJ-S5
	for qemu-devel@nongnu.org; Mon, 08 Oct 2007 10:55:40 -0400
Received: by el-out-1112.google.com with SMTP id y26so243075ele
	for <qemu-devel@nongnu.org>; Mon, 08 Oct 2007 07:55:38 -0700 (PDT)
Message-ID: <470A44E9.8040104@codemonkey.ws>
Date: Mon, 08 Oct 2007 09:55:37 -0500
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] vmmouse with Fedora-6 64bit guest
References: <20070920133626.GA9380@karma.qumranet.com>
	<20070920134132.GA19029@redhat.com>
	<20070925120356.GA4727@karma.qumranet.com>
	<20070925122941.GB4727@karma.qumranet.com>
	<46F9108A.3040307@qumranet.com> <46F91183.4010805@codemonkey.ws>
	<20071008132305.GA8786@karma.qumranet.com>
In-Reply-To: <20071008132305.GA8786@karma.qumranet.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Dan Kenigsberg <danken@qumranet.com>
Cc: qemu-devel@nongnu.org

Dan Kenigsberg wrote:
> In X's vmmouse_drv, the magic number is defined as uint32_t. Therefore
> the top half of the 64 bit ax register is garbage that should be
> ignored. This makes fc6 guest's vmmouse work.
>
>   

I think a better fix would be to change eax from target_ulong to uint32_t.

Regards,

Anthony Liguori

> Index: hw/vmport.c
> ===================================================================
> RCS file: /sources/qemu/qemu/hw/vmport.c,v
> retrieving revision 1.1
> diff -u -p -r1.1 vmport.c
> --- hw/vmport.c	26 Aug 2007 17:48:12 -0000	1.1
> +++ hw/vmport.c	8 Oct 2007 13:11:45 -0000
> @@ -55,7 +55,7 @@ static uint32_t vmport_ioport_read(void 
>      target_ulong eax;
>  
>      eax = s->env->regs[R_EAX];
> -    if (eax != VMPORT_MAGIC)
> +    if ((uint32_t)eax != VMPORT_MAGIC)
>          return eax;
>  
>      command = s->env->regs[R_ECX];
>
>