qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Paolo Bonzini <pbonzini@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>,
	qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
	David Gibson <david@gibson.dropbear.id.au>,
	alex williamson <alex.williamson@redhat.com>,
	mst@redhat.com, Thomas Huth <thuth@redhat.com>
Subject: Re: [Qemu-devel] [PATCH qemu] kvm-irqchip: Only do explicit IRQ routing commit when IRQCHIP is in use
Date: Tue, 2 Aug 2016 15:48:23 -0400 (EDT)	[thread overview]
Message-ID: <471998242.13134246.1470167303059.JavaMail.zimbra@redhat.com> (raw)
In-Reply-To: <20160727133245.GE18777@pxdev.xzpeter.org>

> > > This works too.
> > > 
> > > You may also want to copy if(!kvm_gsi_routing_enabled()) from
> > > kvm_irqchip_add_msi_route() to align API (not needed in my case though).
> > > Or
> > > just check the result of these checks by if(!s->irq_routes) :)
> > > Thanks.
> > 
> > Right. Do you like to post a v2 for this one? (since of course honor
> > is yours and fault is mine :) Please let me know if you want me to do
> > this for you. It'll be nice we have this fix asap so that less people
> > suffers.
> 
> Btw, please ignore above message if you still prefer v1 and sure that
> it works in all cases. :)

Peter, please post v2 according to your patch and Alexey's suggestion.
David, can you handle it?

Thanks!

Paolo

  parent reply	other threads:[~2016-08-02 19:48 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-27  7:51 [Qemu-devel] [PATCH qemu] kvm-irqchip: Only do explicit IRQ routing commit when IRQCHIP is in use Alexey Kardashevskiy
2016-07-27  8:53 ` Peter Xu
2016-07-27 13:14   ` Alexey Kardashevskiy
2016-07-27 13:29     ` Peter Xu
2016-07-27 13:32       ` Peter Xu
2016-07-28  2:20         ` Alexey Kardashevskiy
2016-08-02 19:48         ` Paolo Bonzini [this message]
2016-08-03  3:04           ` Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=471998242.13134246.1470167303059.JavaMail.zimbra@redhat.com \
    --to=pbonzini@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=alex.williamson@redhat.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).