From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38458)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bUfg4-0008Ac-Mr
	for qemu-devel@nongnu.org; Tue, 02 Aug 2016 15:48:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <pbonzini@redhat.com>) id 1bUfg2-0005vT-ST
	for qemu-devel@nongnu.org; Tue, 02 Aug 2016 15:48:35 -0400
Date: Tue, 2 Aug 2016 15:48:23 -0400 (EDT)
From: Paolo Bonzini <pbonzini@redhat.com>
Message-ID: <471998242.13134246.1470167303059.JavaMail.zimbra@redhat.com>
In-Reply-To: <20160727133245.GE18777@pxdev.xzpeter.org>
References: <1469605906-20243-1-git-send-email-aik@ozlabs.ru>
	<20160727085359.GA18777@pxdev.xzpeter.org>
	<2f1d30a2-fe94-1197-381e-f4e3edb7bb1f@ozlabs.ru>
	<20160727132907.GD18777@pxdev.xzpeter.org>
	<20160727133245.GE18777@pxdev.xzpeter.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH qemu] kvm-irqchip: Only do explicit IRQ
 routing commit when IRQCHIP is in use
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Xu <peterx@redhat.com>
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>, qemu-devel@nongnu.org, qemu-ppc@nongnu.org, David Gibson <david@gibson.dropbear.id.au>, alex williamson <alex.williamson@redhat.com>, mst@redhat.com, Thomas Huth <thuth@redhat.com>

> > > This works too.
> > > 
> > > You may also want to copy if(!kvm_gsi_routing_enabled()) from
> > > kvm_irqchip_add_msi_route() to align API (not needed in my case though).
> > > Or
> > > just check the result of these checks by if(!s->irq_routes) :)
> > > Thanks.
> > 
> > Right. Do you like to post a v2 for this one? (since of course honor
> > is yours and fault is mine :) Please let me know if you want me to do
> > this for you. It'll be nice we have this fix asap so that less people
> > suffers.
> 
> Btw, please ignore above message if you still prefer v1 and sure that
> it works in all cases. :)

Peter, please post v2 according to your patch and Alexey's suggestion.
David, can you handle it?

Thanks!

Paolo