From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IjV03-0006gz-Jw for qemu-devel@nongnu.org; Sun, 21 Oct 2007 03:13:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IjV01-0006fy-K5 for qemu-devel@nongnu.org; Sun, 21 Oct 2007 03:13:27 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IjV01-0006fo-Fu for qemu-devel@nongnu.org; Sun, 21 Oct 2007 03:13:25 -0400 Received: from mx20.gnu.org ([199.232.41.8]) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1IjV00-0007wS-Ij for qemu-devel@nongnu.org; Sun, 21 Oct 2007 03:13:24 -0400 Received: from il.qumranet.com ([82.166.9.18]) by mx20.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IjUzt-0007la-W3 for qemu-devel@nongnu.org; Sun, 21 Oct 2007 03:13:18 -0400 Message-ID: <471AFBDE.6080706@qumranet.com> Date: Sun, 21 Oct 2007 09:12:30 +0200 From: Avi Kivity MIME-Version: 1.0 Subject: Re: [Qemu-devel] qemu/hw piix_pci.c References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Thiemo Seufer wrote: > CVSROOT: /sources/qemu > Module name: qemu > Changes by: Thiemo Seufer 07/10/20 20:36:52 > > Modified files: > hw : piix_pci.c > > Log message: > Enable ACPI interrupts, by Igor Lvovsky. > > CVSWeb URLs: > http://cvs.savannah.gnu.org/viewcvs/qemu/hw/piix_pci.c?cvsroot=qemu&r1=1.11&r2=1.12 > > IMO this is a bug. The patch enables the ACPI PCI interrupt every time it is asserted. If this is really needed, this implies that the guest OS detects some sort of inconsistency and keeps turning the ACPI interrupt off. The bug should be addressed instead of worked-around in this way. -- error compiling committee.c: too many arguments to function