From: Fabrice Bellard <fabrice@bellard.org>
To: Blue Swirl <blauwirbel@gmail.com>
Cc: qemu-devel@nongnu.org
Subject: [Qemu-devel] Re: PATCH, RFC: Slirp improvements
Date: Tue, 23 Oct 2007 22:39:05 +0200 [thread overview]
Message-ID: <471E5BE9.9080307@bellard.org> (raw)
> I tried harder to change the SLIRP queue stuff to something saner by
> hiding the pointer access inside inlined functions. Still when I
> changed the 32 bit pointers to native 64 bit (or moved the pointers
> outside the packet), qemu crashes. Must be some devilishly hidden
> access somewhere. I already fixed one, which involved recycling port
> number fields for buffer pointers. IMHO there should be some kind of
> corporeal punishments mandated by law for writing this kind of mess.
> Maybe it would even be easier to create a new userland IP stack based
> on Linux from scratch instead of fixing this.
>
> I think I'll just commit in the log part, unless there are objections.
IMHO you should add a context in the 'struct socket' structure so that
you can avoid adding a context in all the functions manipulating this
structure. The same holds for mbuf.
Regards,
Fabrice.
next reply other threads:[~2007-10-23 20:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-23 20:39 Fabrice Bellard [this message]
2007-10-24 20:04 ` [Qemu-devel] Re: PATCH, RFC: Slirp improvements Blue Swirl
-- strict thread matches above, loose matches on Subject: below --
2007-10-20 18:42 [Qemu-devel] " Blue Swirl
2007-10-23 17:42 ` [Qemu-devel] " Blue Swirl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=471E5BE9.9080307@bellard.org \
--to=fabrice@bellard.org \
--cc=blauwirbel@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).