From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImVCj-0005Gk-7r for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:02:57 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImVCh-0005GT-GG for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:02:56 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImVCh-0005GQ-C3 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:02:55 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImVCg-0000Vd-9v for qemu-devel@nongnu.org; Mon, 29 Oct 2007 10:02:55 -0400 Message-ID: <4725E7ED.6050305@bull.net> Date: Mon, 29 Oct 2007 15:02:21 +0100 From: Laurent Vivier MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom References: <11936114152690-git-send-email-Laurent.Vivier@bull.net> <11936114153499-git-send-email-Laurent.Vivier@bull.net> <20071029132525.GA7128@redhat.com> In-Reply-To: <20071029132525.GA7128@redhat.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=ISO-8859-1; format=flowed Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Daniel P. Berrange" , qemu-devel@nongnu.org Daniel P. Berrange a =E9crit : > On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrote= : >> From: Laurent Vivier >> >> This patch allows to define where is connected the CDROM device (bus, >> unit). >> It extends the "-cdrom" syntax to add these paramaters: >> >> -cdrom file[,if=3Dtype][,bus=3Dn][,unit=3Dm] >> >> where "type" defines the interface (by default, "ide") >> "n" defines the bus number (by default 1) >> "m" defines the unit number (by default 0) >=20 >=20 > Having a separately named arg just for CDROMs was always rather odd/unh= elpful. > I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc unc= hanged > and use the -disk for setting up all types of disks, floppys, cdroms, e= tc. It > would just require one extra field for the -disk arg: >=20 > -disk file[,if=3Dtype][,bus=3Dn][,unit=3Dm][,mode=3Dmode] > =20 > where "type" defines the interface. [ide,scsi,fd] (by default, "ide")= > "n" defines the bus number (by default 1) > "m" defines the unit number (by default 0) > "mode" defines one of [disk,floppy,cdrom] >=20 > If we ever up able to emulate other types of SCSI / IDE devices (tape d= rives, > cdr, dvd perhaps) then the 'mode' can easily be extended to cover them.= I agree with that. And if everyone agrees I can modify patches to do that= =2E.. Laurent --=20 ---------------- Laurent.Vivier@bull.net ----------------- "Given enough eyeballs, all bugs are shallow" E. S. Raymond