From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ImXBF-0007gF-Tx for qemu-devel@nongnu.org; Mon, 29 Oct 2007 12:09:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ImXBE-0007et-G2 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 12:09:32 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ImXBE-0007eo-76 for qemu-devel@nongnu.org; Mon, 29 Oct 2007 12:09:32 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1ImWpb-00033G-3u for qemu-devel@nongnu.org; Mon, 29 Oct 2007 11:47:11 -0400 Received: from localhost (localhost [127.0.0.1]) by ecfrec.frec.bull.fr (Postfix) with ESMTP id 19CA519D97E for ; Mon, 29 Oct 2007 16:46:53 +0100 (CET) Received: from ecfrec.frec.bull.fr ([127.0.0.1]) by localhost (ecfrec.frec.bull.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 24236-03 for ; Mon, 29 Oct 2007 16:46:49 +0100 (CET) Received: from ecn002.frec.bull.fr (ecn002.frec.bull.fr [129.183.4.6]) by ecfrec.frec.bull.fr (Postfix) with ESMTP id 9C2F419D971 for ; Mon, 29 Oct 2007 16:46:49 +0100 (CET) Message-ID: <4726005B.5000902@bull.net> Date: Mon, 29 Oct 2007 16:46:35 +0100 From: Laurent Vivier MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom References: <11936114152690-git-send-email-Laurent.Vivier@bull.net> <11936114153499-git-send-email-Laurent.Vivier@bull.net> <20071029132525.GA7128@redhat.com> <4725E7ED.6050305@bull.net> <20071029140729.GK12592@volumehost.com> In-Reply-To: <20071029140729.GK12592@volumehost.com> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=ISO-8859-1; format=flowed Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org risc@volumehost.com a =E9crit : > On Mon, Oct 29, 2007 at 03:02:21PM +0100, Laurent Vivier wrote: >> Daniel P. Berrange a =E9crit : >>> On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wro= te: >>>> From: Laurent Vivier >>>> >>>> This patch allows to define where is connected the CDROM device (bus= , >>>> unit). >>>> It extends the "-cdrom" syntax to add these paramaters: >>>> >>>> -cdrom file[,if=3Dtype][,bus=3Dn][,unit=3Dm] >>>> >>>> where "type" defines the interface (by default, "ide") >>>> "n" defines the bus number (by default 1) >>>> "m" defines the unit number (by default 0) >>> >>> Having a separately named arg just for CDROMs was always rather=20 >>> odd/unhelpful. >>> I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc=20 >>> unchanged >>> and use the -disk for setting up all types of disks, floppys, cdroms,= etc.=20 >>> It >>> would just require one extra field for the -disk arg: >>> >>> -disk file[,if=3Dtype][,bus=3Dn][,unit=3Dm][,mode=3Dmode] >>> >>> where "type" defines the interface. [ide,scsi,fd] (by default, "ide"= ) >>> "n" defines the bus number (by default 1) >>> "m" defines the unit number (by default 0) >>> "mode" defines one of [disk,floppy,cdrom] >>> >>> If we ever up able to emulate other types of SCSI / IDE devices (tape= =20 >>> drives, >>> cdr, dvd perhaps) then the 'mode' can easily be extended to cover the= m. >> I agree with that. And if everyone agrees I can modify patches to do t= hat... >> >> Laurent >> --=20 >> ---------------- Laurent.Vivier@bull.net ----------------- >> "Given enough eyeballs, all bugs are shallow" E. S. Raymond >> >> >> > not to be rude, but "my" version of the scsi patch supports three contr= ollers, > for a total of 21 disks. might i reccomend you impliment -disk with a c= ontroller, > bus, target syntax, ALA sun? Well, IMHO, bus number should be enough, because the bus identify the=20 controller... but we can discuss that later, as the syntax allows to add = easily=20 a "controller" arg to "-disk". Laurent --=20 ---------------- Laurent.Vivier@bull.net ----------------- "Given enough eyeballs, all bugs are shallow" E. S. Raymond