From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Imcd8-0002Z4-DL for qemu-devel@nongnu.org; Mon, 29 Oct 2007 17:58:42 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Imcd7-0002WE-6N for qemu-devel@nongnu.org; Mon, 29 Oct 2007 17:58:41 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Imcd6-0002Vs-Uv for qemu-devel@nongnu.org; Mon, 29 Oct 2007 17:58:41 -0400 Received: from wr-out-0506.google.com ([64.233.184.235]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Imcd6-0004ax-Ay for qemu-devel@nongnu.org; Mon, 29 Oct 2007 17:58:40 -0400 Received: by wr-out-0506.google.com with SMTP id c38so2423252wra for ; Mon, 29 Oct 2007 14:58:38 -0700 (PDT) Message-ID: <47265789.4090207@codemonkey.ws> Date: Mon, 29 Oct 2007 16:58:33 -0500 From: Anthony Liguori MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom References: <11936114152690-git-send-email-Laurent.Vivier@bull.net> <11936114153499-git-send-email-Laurent.Vivier@bull.net> <20071029132525.GA7128@redhat.com> <20071029152820.GF7128@redhat.com> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org andrzej zaborowski wrote: > On 29/10/2007, Daniel P. Berrange wrote: > >> On Mon, Oct 29, 2007 at 03:49:18PM +0100, andrzej zaborowski wrote: >> >>> On 29/10/2007, Daniel P. Berrange wrote: >>> >>>> On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wrote: >>>> >>>>> From: Laurent Vivier >>>>> >>>>> This patch allows to define where is connected the CDROM device (bus, >>>>> unit). >>>>> It extends the "-cdrom" syntax to add these paramaters: >>>>> >>>>> -cdrom file[,if=type][,bus=n][,unit=m] >>>>> >>>>> where "type" defines the interface (by default, "ide") >>>>> "n" defines the bus number (by default 1) >>>>> "m" defines the unit number (by default 0) >>>>> >>>> Having a separately named arg just for CDROMs was always rather odd/unhelpful. >>>> I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc unchanged >>>> and use the -disk for setting up all types of disks, floppys, cdroms, etc. It >>>> would just require one extra field for the -disk arg: >>>> >>> Sounds logical and I thought this was the plan. I also wouldn't mind >>> having -sda, -sdb... following the intuitive naming based on linux >>> /dev, but IIRC there were some people on the list who didn't like this >>> idea. (I know /dev/sda doesn't have to be an SCSI disk on some recent >>> systems, but it's still the most intuitive name for most users). >>> >> Adding more -sda arguments is just asking for trouble. On recent Fedora, >> even IDE disks will end up as /dev/sdNNN named devices. So what happens >> when you have -hda & -sda at same time.... pain & suffering is what >> happens :-) Avoiding device names as args by just using -disk is nicer >> > > Apart from the -sda discussion (which I still think is the most > intuitive choice, as an alias), I don't think having IDE and SCSI > disks in one machine should be any concern? > I agree that -sda is more intuitive at the moment but I think what Dan is pointing out is that in the future, -hda may end up not being used in the distros at all so while -hda/-sda makes sense today, in a couple years it may become a source of confusion. While -disk seems a bit painful, it probably is the most intuitive thing to use in the long run. Regards, Anthony Liguori > Regards > > > >