From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1InwWm-0003Vu-AU for qemu-devel@nongnu.org; Fri, 02 Nov 2007 09:25:36 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1InwWh-0003Uh-PP for qemu-devel@nongnu.org; Fri, 02 Nov 2007 09:25:35 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1InwWh-0003Ub-Jg for qemu-devel@nongnu.org; Fri, 02 Nov 2007 09:25:31 -0400 Received: from ecfrec.frec.bull.fr ([129.183.4.8]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1InwWf-0003WW-SU for qemu-devel@nongnu.org; Fri, 02 Nov 2007 09:25:31 -0400 Message-ID: <472B250C.4000709@bull.net> Date: Fri, 02 Nov 2007 14:24:28 +0100 From: Laurent Vivier MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH 1/3] Add args to -cdrom to define where is connected the cdrom References: <11936114152690-git-send-email-Laurent.Vivier@bull.net> <11936114153499-git-send-email-Laurent.Vivier@bull.net> <20071029132525.GA7128@redhat.com> <4725E7ED.6050305@bull.net> <20071029143421.GD18384@networkno.de> In-Reply-To: <20071029143421.GD18384@networkno.de> Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=ISO-8859-1; format=flowed Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Thiemo Seufer Cc: qemu-devel@nongnu.org Thiemo Seufer a =E9crit : > Laurent Vivier wrote: >> Daniel P. Berrange a =E9crit : >>> On Sun, Oct 28, 2007 at 11:43:33PM +0100, Laurent.Vivier@bull.net wro= te: >>>> From: Laurent Vivier >>>> >>>> This patch allows to define where is connected the CDROM device (bus= , >>>> unit). >>>> It extends the "-cdrom" syntax to add these paramaters: >>>> >>>> -cdrom file[,if=3Dtype][,bus=3Dn][,unit=3Dm] >>>> >>>> where "type" defines the interface (by default, "ide") >>>> "n" defines the bus number (by default 1) >>>> "m" defines the unit number (by default 0) >>> Having a separately named arg just for CDROMs was always rather=20 >>> odd/unhelpful. >>> I'd suggest that we leave all the -hda,hdb,hdc,-cdrom,-fda,-fdb etc=20 >>> unchanged >>> and use the -disk for setting up all types of disks, floppys, cdroms,= etc.=20 >>> It >>> would just require one extra field for the -disk arg: >>> -disk file[,if=3Dtype][,bus=3Dn][,unit=3Dm][,mode=3Dmode] >>> where "type" defines the interface. [ide,scsi,fd] (by default, "id= e") >>> "n" defines the bus number (by default 1) >>> "m" defines the unit number (by default 0) >>> "mode" defines one of [disk,floppy,cdrom] >>> If we ever up able to emulate other types of SCSI / IDE devices (tape= =20 >>> drives, >>> cdr, dvd perhaps) then the 'mode' can easily be extended to cover the= m. >> I agree with that. And if everyone agrees I can modify patches to do=20 >> that... >=20 > Please go ahead. :-) Well, it is done... is there someone that can comment them ? Or if they are perfect (as usual ;-) ) perhaps it could be included in CV= S ? Regards, Laurent --=20 ---------------- Laurent.Vivier@bull.net ----------------- "Given enough eyeballs, all bugs are shallow" E. S. Raymond