From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyR2N-0006vh-QG for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:39 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyR2L-0006vN-Rw for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:39 -0400 Received: from [199.232.76.173] (port=49584 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyR2L-0006vK-Oi for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:37 -0400 Received: from hall.aurel32.net ([88.191.82.174]:44770) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MyR2L-00020v-BH for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:37 -0400 Received: from [2002:52e8:2fb:1:21e:8cff:feb0:693b] (helo=volta.aurel32.net) by hall.aurel32.net with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.69) (envelope-from ) id 1MyR2J-0006J8-IC for qemu-devel@nongnu.org; Thu, 15 Oct 2009 16:10:35 +0200 Received: from aurel32 by volta.aurel32.net with local (Exim 4.69) (envelope-from ) id 1MyR2H-0002rw-0j for qemu-devel@nongnu.org; Thu, 15 Oct 2009 16:10:33 +0200 Resent-Message-ID: <20091015141033.GA7071@volta.aurel32.net> Resent-To: qemu-devel@nongnu.org MIME-Version: 1.0 In-Reply-To: <20091015094622.GA18638@volta.aurel32.net> References: <473191350910132348y7e9b9738wdf591b0589a9e86a@mail.gmail.com> <20091015094622.GA18638@volta.aurel32.net> Date: Thu, 15 Oct 2009 22:07:12 +0800 Message-ID: <473191350910150707n26e52fcbi8c25b1c80374dbf@mail.gmail.com> Subject: Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present From: Roy Tam Content-Type: text/plain; charset=ISO-8859-1 List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Aurelien Jarno As i8259 in mips_jazz.c is not connect to isa bus correctly, this patch fix that. Signed-off-by: Roy Tam diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c index 3ff367d..281713c 100644 --- a/hw/mips_jazz.c +++ b/hw/mips_jazz.c @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size, /* ISA devices */ i8259 = i8259_init(env->irq[4]); + isa_bus_new(NULL); + isa_bus_irqs(i8259); DMA_init(0); pit = pit_init(0x40, i8259[0]); pcspk_init(pit); 2009/10/15 Aurelien Jarno : > On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote: >> As i8259 in mips_jazz.c is not connect to isa bus correctly, this >> patch fix that. > > It looks fine. Could you please resend the patch with a Signed-off-by: > >> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c >> index 3ff367d..281713c 100644 >> --- a/hw/mips_jazz.c >> +++ b/hw/mips_jazz.c >> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size, >> >> /* ISA devices */ >> i8259 = i8259_init(env->irq[4]); >> + isa_bus_new(NULL); >> + isa_bus_irqs(i8259); >> DMA_init(0); >> pit = pit_init(0x40, i8259[0]); >> pcspk_init(pit); >> >> >> > > -- > Aurelien Jarno GPG: 1024D/F1BCDB73 > aurelien@aurel32.net http://www.aurel32.net >