* [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present
@ 2009-10-14 6:48 Roy Tam
2009-10-15 9:46 ` Aurelien Jarno
0 siblings, 1 reply; 4+ messages in thread
From: Roy Tam @ 2009-10-14 6:48 UTC (permalink / raw)
To: qemu-devel
As i8259 in mips_jazz.c is not connect to isa bus correctly, this
patch fix that.
diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
index 3ff367d..281713c 100644
--- a/hw/mips_jazz.c
+++ b/hw/mips_jazz.c
@@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
/* ISA devices */
i8259 = i8259_init(env->irq[4]);
+ isa_bus_new(NULL);
+ isa_bus_irqs(i8259);
DMA_init(0);
pit = pit_init(0x40, i8259[0]);
pcspk_init(pit);
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present
2009-10-14 6:48 [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present Roy Tam
@ 2009-10-15 9:46 ` Aurelien Jarno
2009-10-15 14:07 ` Roy Tam
2009-10-15 14:10 ` Roy Tam
0 siblings, 2 replies; 4+ messages in thread
From: Aurelien Jarno @ 2009-10-15 9:46 UTC (permalink / raw)
To: Roy Tam; +Cc: qemu-devel
On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote:
> As i8259 in mips_jazz.c is not connect to isa bus correctly, this
> patch fix that.
It looks fine. Could you please resend the patch with a Signed-off-by:
> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
> index 3ff367d..281713c 100644
> --- a/hw/mips_jazz.c
> +++ b/hw/mips_jazz.c
> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
>
> /* ISA devices */
> i8259 = i8259_init(env->irq[4]);
> + isa_bus_new(NULL);
> + isa_bus_irqs(i8259);
> DMA_init(0);
> pit = pit_init(0x40, i8259[0]);
> pcspk_init(pit);
>
>
>
--
Aurelien Jarno GPG: 1024D/F1BCDB73
aurelien@aurel32.net http://www.aurel32.net
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present
2009-10-15 9:46 ` Aurelien Jarno
@ 2009-10-15 14:07 ` Roy Tam
2009-10-15 14:10 ` Roy Tam
1 sibling, 0 replies; 4+ messages in thread
From: Roy Tam @ 2009-10-15 14:07 UTC (permalink / raw)
To: Aurelien Jarno
As i8259 in mips_jazz.c is not connect to isa bus correctly, this
patch fix that.
Signed-off-by: Roy Tam <roytam@gmail.com>
diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
index 3ff367d..281713c 100644
--- a/hw/mips_jazz.c
+++ b/hw/mips_jazz.c
@@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
/* ISA devices */
i8259 = i8259_init(env->irq[4]);
+ isa_bus_new(NULL);
+ isa_bus_irqs(i8259);
DMA_init(0);
pit = pit_init(0x40, i8259[0]);
pcspk_init(pit);
2009/10/15 Aurelien Jarno <aurelien@aurel32.net>:
> On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote:
>> As i8259 in mips_jazz.c is not connect to isa bus correctly, this
>> patch fix that.
>
> It looks fine. Could you please resend the patch with a Signed-off-by:
>
>> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
>> index 3ff367d..281713c 100644
>> --- a/hw/mips_jazz.c
>> +++ b/hw/mips_jazz.c
>> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
>>
>> /* ISA devices */
>> i8259 = i8259_init(env->irq[4]);
>> + isa_bus_new(NULL);
>> + isa_bus_irqs(i8259);
>> DMA_init(0);
>> pit = pit_init(0x40, i8259[0]);
>> pcspk_init(pit);
>>
>>
>>
>
> --
> Aurelien Jarno GPG: 1024D/F1BCDB73
> aurelien@aurel32.net http://www.aurel32.net
>
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present
2009-10-15 9:46 ` Aurelien Jarno
2009-10-15 14:07 ` Roy Tam
@ 2009-10-15 14:10 ` Roy Tam
1 sibling, 0 replies; 4+ messages in thread
From: Roy Tam @ 2009-10-15 14:10 UTC (permalink / raw)
To: qemu-devel
As i8259 in mips_jazz.c is not connect to isa bus correctly, this
patch fix that.
P.S.: just click the wrong button which sent to Aurelien only. resend to list.
Signed-off-by: Roy Tam <roytam@gmail.com>
diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
index 3ff367d..281713c 100644
--- a/hw/mips_jazz.c
+++ b/hw/mips_jazz.c
@@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
/* ISA devices */
i8259 = i8259_init(env->irq[4]);
+ isa_bus_new(NULL);
+ isa_bus_irqs(i8259);
DMA_init(0);
pit = pit_init(0x40, i8259[0]);
pcspk_init(pit);
2009/10/15 Aurelien Jarno <aurelien@aurel32.net>:
> On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote:
>> As i8259 in mips_jazz.c is not connect to isa bus correctly, this
>> patch fix that.
>
> It looks fine. Could you please resend the patch with a Signed-off-by:
>
>> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
>> index 3ff367d..281713c 100644
>> --- a/hw/mips_jazz.c
>> +++ b/hw/mips_jazz.c
>> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
>>
>> /* ISA devices */
>> i8259 = i8259_init(env->irq[4]);
>> + isa_bus_new(NULL);
>> + isa_bus_irqs(i8259);
>> DMA_init(0);
>> pit = pit_init(0x40, i8259[0]);
>> pcspk_init(pit);
>>
>>
>>
>
> --
> Aurelien Jarno GPG: 1024D/F1BCDB73
> aurelien@aurel32.net http://www.aurel32.net
>
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2009-10-15 14:10 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-14 6:48 [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device mc146818rtc with no isa bus present Roy Tam
2009-10-15 9:46 ` Aurelien Jarno
2009-10-15 14:07 ` Roy Tam
2009-10-15 14:10 ` Roy Tam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).