From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1MyR2f-00073R-7m
	for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:57 -0400
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1MyR2a-00071O-8B
	for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:56 -0400
Received: from [199.232.76.173] (port=49592 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1MyR2Z-00071J-Td
	for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:51 -0400
Received: from mail-px0-f179.google.com ([209.85.216.179]:50441)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <roytam@gmail.com>) id 1MyR2Z-00023N-GY
	for qemu-devel@nongnu.org; Thu, 15 Oct 2009 10:10:51 -0400
Received: by pxi9 with SMTP id 9so97134pxi.4
	for <qemu-devel@nongnu.org>; Thu, 15 Oct 2009 07:10:49 -0700 (PDT)
MIME-Version: 1.0
In-Reply-To: <20091015094622.GA18638@volta.aurel32.net>
References: <473191350910132348y7e9b9738wdf591b0589a9e86a@mail.gmail.com>
	<20091015094622.GA18638@volta.aurel32.net>
Date: Thu, 15 Oct 2009 22:10:49 +0800
Message-ID: <473191350910150710o61fa2261h31808d72597946a@mail.gmail.com>
Subject: Re: [Qemu-devel] [PATCH] mips64el: fix: Tried to create isa device
	mc146818rtc with no isa bus present
From: Roy Tam <roytam@gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

As i8259 in mips_jazz.c is not connect to isa bus correctly, this
patch fix that.

P.S.: just click the wrong button which sent to Aurelien only. resend to list.

Signed-off-by: Roy Tam <roytam@gmail.com>

diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
index 3ff367d..281713c 100644
--- a/hw/mips_jazz.c
+++ b/hw/mips_jazz.c
@@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,

     /* ISA devices */
     i8259 = i8259_init(env->irq[4]);
+    isa_bus_new(NULL);
+    isa_bus_irqs(i8259);
     DMA_init(0);
     pit = pit_init(0x40, i8259[0]);
     pcspk_init(pit);

2009/10/15 Aurelien Jarno <aurelien@aurel32.net>:
> On Wed, Oct 14, 2009 at 02:48:21PM +0800, Roy Tam wrote:
>> As i8259 in mips_jazz.c is not connect to isa bus correctly, this
>> patch fix that.
>
> It looks fine. Could you please resend the patch with a Signed-off-by:
>
>> diff --git a/hw/mips_jazz.c b/hw/mips_jazz.c
>> index 3ff367d..281713c 100644
>> --- a/hw/mips_jazz.c
>> +++ b/hw/mips_jazz.c
>> @@ -185,6 +185,8 @@ void mips_jazz_init (ram_addr_t ram_size,
>>
>>      /* ISA devices */
>>      i8259 = i8259_init(env->irq[4]);
>> +    isa_bus_new(NULL);
>> +    isa_bus_irqs(i8259);
>>      DMA_init(0);
>>      pit = pit_init(0x40, i8259[0]);
>>      pcspk_init(pit);
>>
>>
>>
>
> --
> Aurelien Jarno                          GPG: 1024D/F1BCDB73
> aurelien@aurel32.net                 http://www.aurel32.net
>