From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Nd53p-0006e5-F7
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 12:00:09 -0500
Received: from [199.232.76.173] (port=37127 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Nd53o-0006dQ-QW
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 12:00:08 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <roytam@gmail.com>) id 1Nd53n-0005Xy-Hl
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 12:00:08 -0500
Received: from qw-out-1920.google.com ([74.125.92.144]:15748)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <roytam@gmail.com>) id 1Nd53n-0005Xo-9P
	for qemu-devel@nongnu.org; Thu, 04 Feb 2010 12:00:07 -0500
Received: by qw-out-1920.google.com with SMTP id 14so197507qwa.4
	for <qemu-devel@nongnu.org>; Thu, 04 Feb 2010 09:00:05 -0800 (PST)
MIME-Version: 1.0
In-Reply-To: <20100204122414.32e9676e@doriath>
References: <473191351002031830w7876c367vf534508e292c4f04@mail.gmail.com>
	<20100204122414.32e9676e@doriath>
From: Roy Tam <roytam@gmail.com>
Date: Fri, 5 Feb 2010 00:59:37 +0800
Message-ID: <473191351002040859u3d99113dy9143dcdcff0b8566@mail.gmail.com>
Subject: Re: [PATCH] JSON: add %I64d support (Was: Re: [Qemu-devel]
	system_reset command cause assert failed)
Content-Type: text/plain; charset=ISO-8859-1
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Luiz Capitulino <lcapitulino@redhat.com>
Cc: aliguori@us.ibm.com, qemu-devel <qemu-devel@nongnu.org>

2010/2/4 Luiz Capitulino <lcapitulino@redhat.com>:
> On Thu, 4 Feb 2010 10:30:30 +0800
> Roy Tam <roytam@gmail.com> wrote:
>
>> 2010/2/4 Roy Tam <roytam@gmail.com>:
>> > 2010/2/3 Luiz Capitulino <lcapitulino@redhat.com>:
>>
>> OK we are fooled by the json lexer and parser. As we use %I64d to
>> print 'long long' variables in Win32, but lexer and parser only deal
>> with %lld but not %I64d, this patch add support for %I64d and solve
>> 'info pci', 'powser_reset' and 'power_powerdown' assert failure in
>> Win32.
>
>  Hm, I guess this has been suggested before... Anthony?
>

OK I just missed this. And the wheel was reinvented. :-S
http://www.mail-archive.com/qemu-devel@nongnu.org/msg23983.html

>> P.S.: an assert(state.result != NULL) statement in
>> qobject_from_jsonv() will be good for asserting failure of parsing
>> JSON strings.
>
>  Yes, this change is already in a series I plan to send shortly.
>
>  Thanks a lot for tracking this down.
>