From: Roy Tam <roytam@gmail.com>
To: qemu-devel <qemu-devel@nongnu.org>
Subject: [Qemu-devel] Serial: not checking (lsr & UART_LSR_THRE) in IER and not setting thr_ipending (Was Re: Regression: DOSPlus 1.2-je5 doesn't boot correctly since QEMU-0.6.1)
Date: Tue, 23 Feb 2010 14:31:06 +0800 [thread overview]
Message-ID: <473191351002222231y457aa786vff4e186d26b3b052@mail.gmail.com> (raw)
2010/2/23 Roy Tam <roytam@gmail.com>:
> 2010/2/23 Roy Tam <roytam@gmail.com>:
>> 2010/2/23 Roy Tam <roytam@gmail.com>:
>>> Hi all,
>>>
>>> This is an very old regression that DOSPlus 1.2-je5 boots in QEMU
>>> 0.5~0.6.0, and 0.6.1 breaks booting DOSPlus 1.2-je5 till now.
>>>
>>> Floppy Disk Image:
>>> http://roy.reactos.me:9088/files/dp12je5.zip
>>>
>>
>> OK r1049 breaks booting DOSPlus. Is it really fix the serial interrupt issue?
>> http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=60e336dbb837ef4d5053433f9ee391feb102be36
>>
>
> Comment out "s->thr_ipending = 1;" in "if (s->lsr & UART_LSR_THRE)"
> seems fix this issue.
>
bochs implementation doesn't check for (lsr & UART_LSR_THRE) in
IER(addr&7 == 1), I think we need not check for them and setting
thr_ipending. Any serial experts here?
reply other threads:[~2010-02-23 6:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=473191351002222231y457aa786vff4e186d26b3b052@mail.gmail.com \
--to=roytam@gmail.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).