From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1NjoIs-0002TX-8P
	for qemu-devel@nongnu.org; Tue, 23 Feb 2010 01:31:30 -0500
Received: from [199.232.76.173] (port=53383 helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1NjoIr-0002TP-G9
	for qemu-devel@nongnu.org; Tue, 23 Feb 2010 01:31:29 -0500
Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim
	4.60) (envelope-from <roytam@gmail.com>) id 1NjoIq-0008M4-OA
	for qemu-devel@nongnu.org; Tue, 23 Feb 2010 01:31:29 -0500
Received: from mail-px0-f172.google.com ([209.85.216.172]:55074)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <roytam@gmail.com>) id 1NjoIq-0008Lp-Ch
	for qemu-devel@nongnu.org; Tue, 23 Feb 2010 01:31:28 -0500
Received: by pxi2 with SMTP id 2so1388091pxi.27
	for <qemu-devel@nongnu.org>; Mon, 22 Feb 2010 22:31:27 -0800 (PST)
MIME-Version: 1.0
From: Roy Tam <roytam@gmail.com>
Date: Tue, 23 Feb 2010 14:31:06 +0800
Message-ID: <473191351002222231y457aa786vff4e186d26b3b052@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1
Subject: [Qemu-devel] Serial: not checking (lsr & UART_LSR_THRE) in IER and
	not setting
	thr_ipending (Was Re: Regression: DOSPlus 1.2-je5 doesn't boot
	correctly since QEMU-0.6.1)
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel <qemu-devel@nongnu.org>

2010/2/23 Roy Tam <roytam@gmail.com>:
> 2010/2/23 Roy Tam <roytam@gmail.com>:
>> 2010/2/23 Roy Tam <roytam@gmail.com>:
>>> Hi all,
>>>
>>> This is an very old regression that DOSPlus 1.2-je5 boots in QEMU
>>> 0.5~0.6.0, and 0.6.1 breaks booting DOSPlus 1.2-je5 till now.
>>>
>>> Floppy Disk Image:
>>> http://roy.reactos.me:9088/files/dp12je5.zip
>>>
>>
>> OK r1049 breaks booting DOSPlus. Is it really fix the serial interrupt issue?
>> http://git.savannah.gnu.org/cgit/qemu.git/commit/?id=60e336dbb837ef4d5053433f9ee391feb102be36
>>
>
> Comment out "s->thr_ipending = 1;" in "if (s->lsr & UART_LSR_THRE)"
> seems fix this issue.
>

bochs implementation doesn't check for (lsr & UART_LSR_THRE) in
IER(addr&7 == 1), I think we need not check for them and setting
thr_ipending. Any serial experts here?