Re: [Qemu-devel] [PATCH] Serial: DOS Plus regression

[Roy Tam <roytam@gmail.com>]

[-- Attachment #1: Type: text/plain, Size: 705 bytes --]

2010/3/9 Anthony Liguori <anthony@codemonkey.ws>
>
> On 02/28/2010 02:03 AM, Roy Tam wrote:
>>
>> The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
>> booting Digital Research DOSPlus. Following patch partially reverts
>> that commit and makes DOSPlus booting in QEMU again.
>>
>> Sign-off-by: Roy Tam<roytam@gmail.com>
>>
>> --
>>
>> diff --git a/hw/serial.c b/hw/serial.c
>> index df67383..cf23aad 100644
>> --- a/hw/serial.c
>> +++ b/hw/serial.c
>> @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
>> uint32_t addr, uint32_t val)
>>
>
> This patch is whitespace damaged.
>
> Regards,
>
> Anthony Liguori
>

GMail wrapped the mail. Sorry about that.
Patch file attached.

[-- Attachment #2: serial-ier-fix.patch --]
[-- Type: application/octet-stream, Size: 449 bytes --]

diff --git a/hw/serial.c b/hw/serial.c
index f3ec36a..2ae550e 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque, uint32_t addr, uint32_t val)
                      s->poll_msl = 0;
                 }
             }
-            if (s->lsr & UART_LSR_THRE) {
-                s->thr_ipending = 1;
-                serial_update_irq(s);
-            }
         }
         break;
     case 2: