* [Qemu-devel] [PATCH] Serial: DOS Plus regression
@ 2010-02-28 8:03 Roy Tam
2010-03-09 15:05 ` Anthony Liguori
0 siblings, 1 reply; 3+ messages in thread
From: Roy Tam @ 2010-02-28 8:03 UTC (permalink / raw)
To: qemu-devel
The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
booting Digital Research DOSPlus. Following patch partially reverts
that commit and makes DOSPlus booting in QEMU again.
Sign-off-by: Roy Tam <roytam@gmail.com>
--
diff --git a/hw/serial.c b/hw/serial.c
index df67383..cf23aad 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
uint32_t addr, uint32_t val)
s->poll_msl = 0;
}
}
- if (s->lsr & UART_LSR_THRE) {
- s->thr_ipending = 1;
- serial_update_irq(s);
- }
}
break;
case 2:
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Serial: DOS Plus regression
2010-02-28 8:03 [Qemu-devel] [PATCH] Serial: DOS Plus regression Roy Tam
@ 2010-03-09 15:05 ` Anthony Liguori
2010-03-09 15:39 ` Roy Tam
0 siblings, 1 reply; 3+ messages in thread
From: Anthony Liguori @ 2010-03-09 15:05 UTC (permalink / raw)
To: Roy Tam; +Cc: qemu-devel
On 02/28/2010 02:03 AM, Roy Tam wrote:
> The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
> booting Digital Research DOSPlus. Following patch partially reverts
> that commit and makes DOSPlus booting in QEMU again.
>
> Sign-off-by: Roy Tam<roytam@gmail.com>
>
> --
>
> diff --git a/hw/serial.c b/hw/serial.c
> index df67383..cf23aad 100644
> --- a/hw/serial.c
> +++ b/hw/serial.c
> @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
> uint32_t addr, uint32_t val)
>
This patch is whitespace damaged.
Regards,
Anthony Liguori
> s->poll_msl = 0;
> }
> }
> - if (s->lsr& UART_LSR_THRE) {
> - s->thr_ipending = 1;
> - serial_update_irq(s);
> - }
> }
> break;
> case 2:
>
>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] Serial: DOS Plus regression
2010-03-09 15:05 ` Anthony Liguori
@ 2010-03-09 15:39 ` Roy Tam
0 siblings, 0 replies; 3+ messages in thread
From: Roy Tam @ 2010-03-09 15:39 UTC (permalink / raw)
To: Anthony Liguori; +Cc: qemu-devel
[-- Attachment #1: Type: text/plain, Size: 705 bytes --]
2010/3/9 Anthony Liguori <anthony@codemonkey.ws>
>
> On 02/28/2010 02:03 AM, Roy Tam wrote:
>>
>> The commit in r1049 (serial interrupt fix (Hampa Hug)) prevents
>> booting Digital Research DOSPlus. Following patch partially reverts
>> that commit and makes DOSPlus booting in QEMU again.
>>
>> Sign-off-by: Roy Tam<roytam@gmail.com>
>>
>> --
>>
>> diff --git a/hw/serial.c b/hw/serial.c
>> index df67383..cf23aad 100644
>> --- a/hw/serial.c
>> +++ b/hw/serial.c
>> @@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque,
>> uint32_t addr, uint32_t val)
>>
>
> This patch is whitespace damaged.
>
> Regards,
>
> Anthony Liguori
>
GMail wrapped the mail. Sorry about that.
Patch file attached.
[-- Attachment #2: serial-ier-fix.patch --]
[-- Type: application/octet-stream, Size: 449 bytes --]
diff --git a/hw/serial.c b/hw/serial.c
index f3ec36a..2ae550e 100644
--- a/hw/serial.c
+++ b/hw/serial.c
@@ -401,10 +401,6 @@ static void serial_ioport_write(void *opaque, uint32_t addr, uint32_t val)
s->poll_msl = 0;
}
}
- if (s->lsr & UART_LSR_THRE) {
- s->thr_ipending = 1;
- serial_update_irq(s);
- }
}
break;
case 2:
^ permalink raw reply related [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-09 15:39 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-28 8:03 [Qemu-devel] [PATCH] Serial: DOS Plus regression Roy Tam
2010-03-09 15:05 ` Anthony Liguori
2010-03-09 15:39 ` Roy Tam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).