From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1Iponm-0006kr-KW
	for qemu-devel@nongnu.org; Wed, 07 Nov 2007 12:34:54 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1Iponk-0006kX-PQ
	for qemu-devel@nongnu.org; Wed, 07 Nov 2007 12:34:53 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1Iponk-0006kU-KH
	for qemu-devel@nongnu.org; Wed, 07 Nov 2007 12:34:52 -0500
Received: from sp604002mt.neufgp.fr ([84.96.92.61] helo=sMtp.neuf.fr)
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1Iponj-0002Wk-Ug
	for qemu-devel@nongnu.org; Wed, 07 Nov 2007 12:34:52 -0500
Received: from [84.102.211.92] by sp604002mt.gpm.neuf.ld
	(Sun Java System Messaging Server 6.2-5.05 (built Feb 16 2006))
	with ESMTP id <0JR50066Y9TM41O2@sp604002mt.gpm.neuf.ld> for
	qemu-devel@nongnu.org; Wed, 07 Nov 2007 17:29:48 +0100 (CET)
Date: Wed, 07 Nov 2007 17:29:23 +0100
From: Fabrice Bellard <fabrice@bellard.org>
Subject: Re: [Qemu-devel] [PATCH] Add TPM support
In-reply-to: <20071107120530.GC7624@thomas>
Message-id: <4731E7E3.4020602@bellard.org>
MIME-version: 1.0
Content-type: text/plain; charset=ISO-8859-1
Content-transfer-encoding: 7BIT
References: <20071031120636.GA7567@thomas> <20071031125438.GG7712@networkno.de>
	<20071031141020.GC7567@thomas> <20071031161427.GI7712@networkno.de>
	<20071101155556.GC15568@thomas> <20071105141528.GE8650@thomas>
	<472F3966.1090206@bellard.org> <20071106080734.GB7621@thomas>
	<4730C497.5070201@bellard.org> <20071107120530.GC7624@thomas>
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

A few more remarks :

- tpm_register() must be called in hw/pc.c.

- you must also handle incomplete write and reads. Use something like
unix_write() in vl.c and the equivalent for read.

- The code seems to be Unix specific so it must be disabled for win32.

Regards,

Fabrice.