qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fabrice Bellard <fabrice@bellard.org>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] Removal of some target CPU macros
Date: Wed, 07 Nov 2007 19:32:02 +0100	[thread overview]
Message-ID: <473204A2.3030208@bellard.org> (raw)

I noticed that some target CPUs macros have been added while they do not
seem necessary. I don't like that because it introduces more #ifdefs
which prevent making a version supporting simultaneously all the CPUs.

In particular I saw the following:

- TARGET_MIPSN32 : it is always combined with TARGET_MIPS64 in
target-mips/. If its only usage is to select a different Linux ABI, then
I suggest keeping TARGET_MIPS64 and using another define to choose that.

- TARGET_PPC64H, TARGET_PPCEMB : I see no reason why they cannot be
handled dynamically as the other PowerPC CPU types, provided that
TARGET_PPC64 is defined. Is it the long term plan ?

Regards,

Fabrice.

             reply	other threads:[~2007-11-07 18:32 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-07 18:32 Fabrice Bellard [this message]
2007-11-07 19:16 ` [Qemu-devel] Removal of some target CPU macros Jocelyn Mayer
2007-11-07 21:55   ` Fabrice Bellard
2007-11-07 22:28     ` J. Mayer
2007-11-07 22:55       ` Fabrice Bellard
2007-11-07 23:12         ` Bernhard Fischer
2007-11-07 23:36           ` Paul Brook
     [not found]       ` <200711072247.53354.paul@codesourcery.com>
2007-11-07 23:06         ` J. Mayer
2007-11-07 23:37           ` Paul Brook
2007-11-09 22:04             ` J. Mayer
2007-11-08 13:09   ` Tristan Gingold
2007-11-08 20:09     ` J. Mayer
2007-11-07 22:40 ` Thiemo Seufer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=473204A2.3030208@bellard.org \
    --to=fabrice@bellard.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).