From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1IsoAi-00072Y-V2
	for qemu-devel@nongnu.org; Thu, 15 Nov 2007 18:30:57 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1IsoAi-000703-76
	for qemu-devel@nongnu.org; Thu, 15 Nov 2007 18:30:56 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1IsoAh-0006zW-PU
	for qemu-devel@nongnu.org; Thu, 15 Nov 2007 18:30:55 -0500
Received: from pop-tawny.atl.sa.earthlink.net ([207.69.195.67])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <reif@earthlink.net>) id 1IsoAh-0001xO-B2
	for qemu-devel@nongnu.org; Thu, 15 Nov 2007 18:30:55 -0500
Received: from user-142h2k8.cable.mindspring.com ([72.40.138.136]
	helo=earthlink.net)
	by pop-tawny.atl.sa.earthlink.net with esmtp (Exim 3.36 #1)
	id 1IsoAg-00062I-00
	for qemu-devel@nongnu.org; Thu, 15 Nov 2007 18:30:54 -0500
Message-ID: <473CD6AE.8090309@earthlink.net>
Date: Thu, 15 Nov 2007 18:30:54 -0500
From: Robert Reif <reif@earthlink.net>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------000506000303010201070808"
Subject: [Qemu-devel] [PATCH] sparc32 fix MXCC error bit clearing
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

This is a multi-part message in MIME format.
--------------000506000303010201070808
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit

Fix MXCC error register bit clearing.

--------------000506000303010201070808
Content-Type: text/plain;
 name="reset1.diff.txt"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
 filename="reset1.diff.txt"

Index: target-sparc/op_helper.c
===================================================================
RCS file: /sources/qemu/qemu/target-sparc/op_helper.c,v
retrieving revision 1.52
diff -p -u -r1.52 op_helper.c
--- target-sparc/op_helper.c	11 Nov 2007 19:46:09 -0000	1.52
+++ target-sparc/op_helper.c	15 Nov 2007 23:28:12 -0000
@@ -438,13 +446,11 @@ void helper_st_asi(int asi, int size)
                 DPRINTF_MXCC("%08x: unimplemented access size: %d\n", T0, size);
             break;
         case 0x01c00e00: /* MXCC error register  */
+            // writing a 1 bit clears the error
             if (size == 8)
-                env->mxccregs[6] = ((uint64_t)T1 << 32) | T2;
+                env->mxccregs[6] &= ~(((uint64_t)T1 << 32) | T2);
             else
                 DPRINTF_MXCC("%08x: unimplemented access size: %d\n", T0, size);
-            if (env->mxccregs[6] == 0xffffffffffffffffULL) {
-                // this is probably a reset
-            }
             break;
         case 0x01c00f00: /* MBus port address register */
             if (size == 8)

--------------000506000303010201070808--