From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: "Alex Bennée" <alex.bennee@linaro.org>, qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"reviewer:Incompatible changes" <libvir-list@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: Re: [RFC PATCH] build: deprecate --enable-gprof builds and remove from CI
Date: Tue, 31 Jan 2023 11:55:04 +0100 [thread overview]
Message-ID: <474f93a6-2b16-2fc7-2b1c-516e61109ecd@linaro.org> (raw)
In-Reply-To: <069349bb-a09f-bac4-3a99-70699bd4fa54@linaro.org>
On 31/1/23 11:36, Philippe Mathieu-Daudé wrote:
> On 31/1/23 10:42, Alex Bennée wrote:
>> As gprof relies on instrumentation you rarely get useful data compared
>> to a real optimised build. Lets deprecate the build option and
>> simplify the CI configuration as a result.
>>
>> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>> Cc: Thomas Huth <thuth@redhat.com>
>> ---
>> docs/about/deprecated.rst | 14 ++++++++++++++
>> meson.build | 7 ++++++-
>> .gitlab-ci.d/buildtest.yml | 19 ++++---------------
>> meson_options.txt | 3 ++-
>> 4 files changed, 26 insertions(+), 17 deletions(-)
>
> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
(Tracked as https://gitlab.com/qemu-project/qemu/-/issues/1338)
next prev parent reply other threads:[~2023-01-31 10:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 9:42 [RFC PATCH] build: deprecate --enable-gprof builds and remove from CI Alex Bennée
2023-01-31 10:36 ` Philippe Mathieu-Daudé
2023-01-31 10:55 ` Philippe Mathieu-Daudé [this message]
2023-01-31 10:56 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=474f93a6-2b16-2fc7-2b1c-516e61109ecd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=libvir-list@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).