From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J0kN5-0007bX-1a
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 16:04:31 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J0kN3-0007ZT-EN
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 16:04:30 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J0kN3-0007ZG-9u
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 16:04:29 -0500
Received: from an-out-0708.google.com ([209.85.132.245])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1J0kN3-0005Zh-76
	for qemu-devel@nongnu.org; Fri, 07 Dec 2007 16:04:29 -0500
Received: by an-out-0708.google.com with SMTP id b38so455197ana
	for <qemu-devel@nongnu.org>; Fri, 07 Dec 2007 13:04:27 -0800 (PST)
Message-ID: <4759B559.1070405@codemonkey.ws>
Date: Fri, 07 Dec 2007 15:04:25 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
References: <37bf559ffcf74bfe62ec.1197059815@localhost.localdomain>
	<4759B1A9.5080302@codemonkey.ws>
	<20071207205250.GF23913@us.ibm.com>
In-Reply-To: <20071207205250.GF23913@us.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: [Qemu-devel] Re: [kvm-devel] [PATCH 1 of 3] export SMBIOS/DMI
	tables to PC machines
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Ryan Harper <ryanh@us.ibm.com>
Cc: kvm-devel@lists.sourceforge.net, qemu-devel@nongnu.org

Ryan Harper wrote:
> * Anthony Liguori <anthony@codemonkey.ws> [2007-12-07 14:49]:
>   
>>> +
>>> +CPUState *first_cpu;
>>>  
>>>       
>> This should probably be static.
>>     
>
> doh, should be extern actually since it's defined elsewhere.
>   

Perhaps you want cpu_single_env instead of first_cpu?

Regards,

Anthony Liguori