From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J1lIR-0003IQ-Ht
	for qemu-devel@nongnu.org; Mon, 10 Dec 2007 11:15:55 -0500
Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43)
	id 1J1lIP-0003Ct-FS
	for qemu-devel@nongnu.org; Mon, 10 Dec 2007 11:15:54 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J1lIP-0003Ce-Aw
	for qemu-devel@nongnu.org; Mon, 10 Dec 2007 11:15:53 -0500
Received: from rv-out-0910.google.com ([209.85.198.189])
	by monty-python.gnu.org with esmtp (Exim 4.60)
	(envelope-from <anthony@codemonkey.ws>) id 1J1lIP-0007S0-5E
	for qemu-devel@nongnu.org; Mon, 10 Dec 2007 11:15:53 -0500
Received: by rv-out-0910.google.com with SMTP id g11so6023001rvb
	for <qemu-devel@nongnu.org>; Mon, 10 Dec 2007 08:15:52 -0800 (PST)
Message-ID: <475D6636.70205@codemonkey.ws>
Date: Mon, 10 Dec 2007 10:15:50 -0600
From: Anthony Liguori <anthony@codemonkey.ws>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] Capture network traffic to a tcpdump file
	- updated
References: <380128.17287.qm@web57002.mail.re3.yahoo.com>
	<475D5CF2.1020202@codemonkey.ws>
	<200712101605.39168.paul@codesourcery.com>
In-Reply-To: <200712101605.39168.paul@codesourcery.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Paul Brook <paul@codesourcery.com>
Cc: qemu-devel@nongnu.org

Paul Brook wrote:
> On Monday 10 December 2007, Anthony Liguori wrote:
>   
>> Balazs Attila-Mihaly (Cd-MaN) wrote:
>>     
>>> Here goes v0.2 for my patch :-)
>>> Changes
>>> - now the option is a separate command line switch:
>>>   -net capture,vlan=2,file=test.pcap
>>>       
>> Is it really necessary/useful to specify this on the command line since
>> it can be controlled from the monitor?
>>     
>
> By that argument you could remove half the rest of the commandline options 
> (e.g. the USB options).
>   

I was thinking about the use-case.  For instance, you probably want to 
start and end the capture at specific times.  I don't think the common 
case it trapping traffic for the entire duration the guest is running.

Regards,

Anthony Liguori

> I think it would be good to expose the whole -net functionality via the 
> monitor, rather than have a special hack for -net monitor. Obviously some 
> functionality would only be usable via the commandline (e.g. non-hotplug 
> NICs)
>   

> Paul
>
>