From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43)
	id 1J21CY-0003Mx-Hg
	for qemu-devel@nongnu.org; Tue, 11 Dec 2007 04:14:54 -0500
Received: from [199.232.76.173] (helo=monty-python.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1J21CX-0003LB-Dn
	for qemu-devel@nongnu.org; Tue, 11 Dec 2007 04:14:53 -0500
Received: from mx1.polytechnique.org ([129.104.30.34])
	by monty-python.gnu.org with esmtps
	(TLS-1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.60)
	(envelope-from <fabrice@bellard.org>) id 1J21CX-000852-1f
	for qemu-devel@nongnu.org; Tue, 11 Dec 2007 04:14:53 -0500
Received: from fbe1.dev.netgem.com (gw.netgem.com [195.68.2.34])
	(using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by ssl.polytechnique.org (Postfix) with ESMTP id 94CDB3317A
	for <qemu-devel@nongnu.org>; Tue, 11 Dec 2007 10:14:49 +0100 (CET)
Message-ID: <475E5509.4060208@bellard.org>
Date: Tue, 11 Dec 2007 10:14:49 +0100
From: Fabrice Bellard <fabrice@bellard.org>
MIME-Version: 1.0
Subject: Re: [Qemu-devel] Re: [PATCH] mark host pages as reserved
References: <aec7e5c30712050045u79bcf3abkf93c2d7dbb067a8b@mail.gmail.com>
	<aec7e5c30712101921lb863972ld1af1a01ed5d9eef@mail.gmail.com>
In-Reply-To: <aec7e5c30712101921lb863972ld1af1a01ed5d9eef@mail.gmail.com>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Reply-To: qemu-devel@nongnu.org
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/pipermail/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: qemu-devel@nongnu.org

Magnus Damm wrote:
> Hi everyone,
> 
> On Dec 5, 2007 5:45 PM, Magnus Damm <magnus.damm@gmail.com> wrote:
>> Hi all,
>>
>> This patch teaches the user space emulator about host pages. It marks
>> present host page mappings with PAGE_RESERVED so mmap_find_vma()
>> properly can detect that pages at mmap_next_start should be skipped
>> over instead of being overwritten using mmap(). Without this patch I
>> experience crashes with the arm or sh4 user space emulator together
>> with sbox2. This combination sometimes result in that host libraries
>> are mapped into the qemu process space starting from 0x4xxxxxxx
>> instead of 0xb7xxxxxx. This together with the initial value of
>> mmap_next_start results in a segfault when the elf loader overwrites
>> the mapped host libraries with the target binary.
>>
>> Comments anyone?
> 
> Any reason for not applying this patch? This fixes user space
> emulation for all targets.

It seems OK.

Fabrice.