From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1J2acJ-0006aP-Do for qemu-devel@nongnu.org; Wed, 12 Dec 2007 18:03:51 -0500 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1J2acI-0006ZS-NC for qemu-devel@nongnu.org; Wed, 12 Dec 2007 18:03:50 -0500 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1J2acI-0006Z8-Fo for qemu-devel@nongnu.org; Wed, 12 Dec 2007 18:03:50 -0500 Received: from sp604003av.neufgp.fr ([84.96.92.124] helo=neuf-infra-smtp-out-sp604003av.neufgp.fr) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1J2acH-0002TR-QC for qemu-devel@nongnu.org; Wed, 12 Dec 2007 18:03:50 -0500 Message-ID: <476068AA.80001@bellard.org> Date: Thu, 13 Dec 2007 00:03:06 +0100 From: Fabrice Bellard MIME-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] arm eabi TLS References: <1197420297.2947.94.camel@phantasm.home.enterpriseandprosperity.com> In-Reply-To: <1197420297.2947.94.camel@phantasm.home.enterpriseandprosperity.com> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Reply-To: qemu-devel@nongnu.org List-Id: qemu-devel.nongnu.org List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: thayne@c2.net, qemu-devel@nongnu.org Thayne Harbaugh wrote: > I believe Paul Brook did the original patch for arm eabi TLS. The patch > has bounced around for a bit but hasn't been applied. We've been using > this patch for a while and have tweaked it to be a bit more correct as > far as code organization. > > Please let me know what else should be improved for this so that it can > be applied. - the clone() syscall must be disabled when it is used to create a thread because it cannot work reliably in its current state. - the system to intercept calls to the syscall page must be made more generic to be used at least by arm user and x86_64 user. - It would be good to limit the changes in the CPU emulation code to handle the TLS. For example, on MIPS, the TLS register must not be stored in the CPU state. Same for ARM. Regards, Fabrice.